java.lang.NullPointerException with boolean

Question

I wrote a realy simple code based on another question and here it is:

It throws me an error

java.lang.NullPointerException line 5 and 17

I don't know what I'm doing wrong.

 public class Main {

    public static String bool(Boolean param){
        if(param == true){    (line 5)
            return "a";
        }else if(param == false){
            return "b";
        }
        return "c";

    }

    public static void main(String[] args){

        System.out.println(bool(true));
        System.out.println(bool(null)); (line 17)
        System.out.println(bool(false));


    }
}

One reason to avoid using Boolean (or other wrapper class types) if at all possible, or if you must use it, test it for null before using it. — Hovercraft Full Of Eels
– Hovercraft Full Of Eels, Commented Sep 13, 2014 at 14:43
@HovercraftFullOfEels This is our friend from a few minutes ago, testing out the solution to his assignment question :) — Marko Topolnik
– Marko Topolnik, Commented Sep 13, 2014 at 14:44
possible duplicate of Why comparing Integer with int can throw NullPointerException in Java? — Joe
– Joe, Commented Sep 14, 2014 at 6:13

Marko Topolnik · Accepted Answer · 2014-09-13 14:55:00Z

47

null cannot be auto-unboxed to a primitive boolean value, which is what happens when you try to compare it with true. In

param == true

The type of true is boolean, therefore the left-hand operand must also be a boolean. You are passing in a Boolean, which is an object, but can be auto-unboxed to boolean.

Therefore this is equivalent to

param.booleanValue() == true

Clearly, if param is null, the above throws NullPointerException.

To avoid the hidden pitfalls of auto-unboxing, you could instead work with the Boolean objects:

if (Boolean.TRUE.equals(param))
  return "a";
if (Boolean.FALSE.equals(param))
  return "b";
return "c";

edited Sep 13, 2014 at 14:55

answered Sep 13, 2014 at 14:41

Marko Topolnik

201k31 gold badges336 silver badges455 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Japheth Ongeri - inkalimeva Over a year ago

Great trick with the Boolean statics and methods, it simplifies code so much! +1

sorin.silaghi Over a year ago

This also works: import static java.lang.Boolean.TRUE; if (param == TRUE) {}

Marko Topolnik Over a year ago

@sorin7486 It doesn't work in general: new Boolean(true) != Boolean.TRUE.

sorin.silaghi Over a year ago

@MarkoTopolnik you are correct.. have I mentioned I don't like java? :)

Mureinik · Accepted Answer · 2019-05-26 15:39:56Z

1

Your code compares a java.lang.Boolean instance with a primitive boolean, which means unboxing the java.lang.Boolean. Since null can't be unboxed, a NullPointerException is thrown.

You could work around this by using the built in constants Boolean.TRUE and Boolean.FALSE:

public static String bool(Boolean param) {
    if (Boolean.TRUE.equals(param)) {
        return "a";
    } else if (Boolean.FALSE.equals(param)) {
        return "b";
    }
    return "c";
}

edited May 26, 2019 at 15:39

answered Sep 13, 2014 at 14:47

Mureinik

316k54 gold badges399 silver badges405 bronze badges

1 Comment

Japheth Ongeri - inkalimeva Over a year ago

Great trick with the Boolean statics and methods, it simplifies code so much! +1

Alex · Accepted Answer · 2014-09-13 14:46:56Z

0

You used the Boolean instead of boolean. Boolean is a class, which means you can assign objects to it. In your case, you passed in a null, which is then assigned to param. You then tried to use param, which of course resulted in a NullPointerException.

You can:

Get rid of the line bool(null)
Change Boolean to boolean in the parameters for bool()
Add an else if for when param is null

answered Sep 13, 2014 at 14:46

Alex

3,1917 gold badges32 silver badges46 bronze badges

Comments

Govind · Accepted Answer · 2014-09-13 15:07:02Z

0

So your program must be something like this.

public class BooleanBug {

    public static String bool(Boolean param) {
        if ((null != param) && param.booleanValue() == true) {
            return "a";
        } else if ((null != param) && param.booleanValue() == false) {
            return "b";
        }
        return "c";

    }

    public static void main(String[] args) {

        System.out.println(bool(true));
        System.out.println(bool(null));
        System.out.println(bool(false));

    }
}

answered Sep 13, 2014 at 15:07

Govind

3111 silver badge12 bronze badges

Comments

Nikunj Trivedi · Accepted Answer · 2021-07-21 06:09:40Z

0

Clearly, as mentioned by others if param is null, the below throws NullPointerException.

param == true

According to the Java language specification, unboxing happens via calling Boolean.booleanValue(), Number.longValue(), Number.intValue() etc. Its like calling those methods manually and NullPointerException is the result of unboxing a null.

We can also detect these Unboxing vulnerabilities, if not handled properly using static code analysis tools. Kindly refer this for more information Boolean Violation

answered Jul 21, 2021 at 6:09

Nikunj Trivedi

911 silver badge4 bronze badges

Collectives™ on Stack Overflow

java.lang.NullPointerException with boolean

5 Answers 5

4 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related