assign value of service property (Angularjs)

Question

I try to assign a property of a service object by using the $http but I have confusing results. Why this doesn't work (here is my code):

.service('config', function ($http) {
    var config = {
        get_host: function () {
            if (online == 0) {
                return offlineHost;
            }
            return onlineHost;
        },
        online: 'false',
        host: 'false',
        checkConnection: function () {

            //this wont work;
            /* 
            $http.get(this.host + http_url ).then(function(response) { 
                return  response.data.ping;
            });
            */

            //this will work 
            return 'oke';
        },

        _load: function () {
            this.host = this.get_host();
            this.online = this.checkConnection();
            this.url_api = this.host + http_url;

            if (this.online == 1) {
                this.offline_message = 'Maaf aplikasi tidak bisa terkoneksi dengan server atau anda offline';
            }
        }
    };

    //run constructor and get value;
    config._load();

    return config;

}) //end config class

In my controller :

var online = config.online;
alert(online) //return undefined, but the $http request on firebug is showed return value

IT Warrior · Accepted Answer · 2014-09-15 01:44:57Z

1

service:

.service('config', function ($http, $q) {
var config = {
    get_host: function () {
        if (online == 0) {
            return offlineHost;
        }
        return onlineHost;
    },
    online: 'false',
    host: 'false',
    checkConnection: function () {
        var deferred = $q.defer();

        $http.get(this.host + http_url ).then(function(response) { 
            $q.resolve(response.data.ping);
        });

        return $q.promise;
    },

    _load: function () {
        this.host = this.get_host();
        this.online = this.checkConnection();
        this.url_api = this.host + http_url;

        if (this.online == 1) {
            this.offline_message = 'Maaf aplikasi tidak bisa terkoneksi dengan server atau anda offline';
        }
    }
};

//run constructor and get value;
config._load();

return config;

}) //end config class

controller:

config.online.then(function(data){
    alert(data);
    var online = data;
    handleDate(online); // this is a predefined function to handle your data when it's downloaded
});

edited Sep 15, 2014 at 1:44

answered Sep 14, 2014 at 0:35

IT Warrior

1,53014 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

navotera Over a year ago

i try your suggestion but what make me confuse is in this point :

var online = config.online.then(function(data){     data.response;      //this alert is working      //alert(data.response);           });    //this alert not work (return object)   alert(online);

navotera Over a year ago

sorry i cannot vote u up, my rep > 15 but thanks anyway

Michał Miszczyszyn · Accepted Answer · 2014-09-15 11:54:25Z

0

That's because the $http service calls are asynchronous.

The easiest way to handle this is to make your service return a promise:

return $http.get(this.host + http_url);

(return in front of $http is crucial here). Then anywhere in the code:

config.checkConnection().then(function(response) { 
    // there you get the response.data.ping
});

See your modified and simplified code here: http://plnkr.co/edit/cCHXCLCG3xJUwAPPlJ3x?p=preview

You can read more about that:

edited Sep 15, 2014 at 11:54

answered Sep 13, 2014 at 22:53

Michał Miszczyszyn

12.8k2 gold badges38 silver badges53 bronze badges

Collectives™ on Stack Overflow

assign value of service property (Angularjs)

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related