how to check checkboxes in javascript

Question

I have three checkboxes in html.
In Javascript I have variable newspaper = "jang,News,Dawn";

Now I want to check the checkboxes based on newspaper values if it contain only jang then only jang check box should be checked if it contain jang,News,Dawn then all three checkbox should be checked.

The code I have written always checked last two checkboxes which is wrong.

My code is:

var newspaper = document.forms[0].newspaper;
var a = "Jang,News";

var news = ["Jang", "Dawn", "News"]
for (i = 0; i < news.length; i++)
{
    if (a.indexOf(news[i]))
    {
        newspaper[i].checked = true;
    }
}

<input type="checkbox" name="newspaper[]"  value="Jang">Jang<br />
<input type="checkbox" name="newspaper[]"  value="Dawn">Dawn<br />
<input type="checkbox" name="newspaper[]"  value="News">The News

also a.indexOf(news[i]) >= 0) to allow match on the first char — AlexanderBrevig
– AlexanderBrevig, Commented Sep 16, 2014 at 11:44

Prateek · Accepted Answer · 2014-09-16 11:57:33Z

2

If you want to do it using Javascript only, you have to do some changes in your code :

Change the name of all the checkboxes to "newspaper" (without square brackets)

<input type="checkbox" name="newspaper"  value="Jang"/>Jang<br />
<input type="checkbox" name="newspaper"  value="Dawn"/>Dawn<br />
<input type="checkbox" name="newspaper"  value="News"/>The News

Check indexOf return value is not equal to -1 :

if (a.indexOf(news[i]) != -1) {
    newspaper[i].checked = true;
}

Here is the working demo.

answered Sep 16, 2014 at 11:57

Prateek

4,5302 gold badges19 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mardoxx · Accepted Answer · 2014-09-16 11:54:22Z

0

var newspaper = document.forms[0]["newspaper[]"];
var a = "Jang,News";
for (i = 0; i < newspaper.length; i++)
{
       if(a.indexOf(newspaper[i].value) > -1){
             newspaper[i].checked = true;
          }
}

Yeah, I would review your code, and the names of your elements. But here, this works.

http://jsfiddle.net/3qeeox0a/

answered Sep 16, 2014 at 11:54

Mardoxx

4,5028 gold badges44 silver badges70 bronze badges

Comments

V2Solutions - MS Team · Accepted Answer · 2014-09-16 12:58:14Z

0

Try this-

var newspaper = document.forms[0].newspaper;
    var a = "Jang,News";

    var news = ["Jang","Dawn", "News"]
    for (i = 0; i < news.length; i++)
    {
        if (a.indexOf(news[i]) != 1)
        {
            newspaper[i].checked = true;
        }
    }

Fiddle:-http://jsfiddle.net/um0y5wrp/9/

answered Sep 16, 2014 at 12:58

V2Solutions - MS Team

1,1276 silver badges6 bronze badges

Comments

Pang · Accepted Answer · 2015-02-23 01:02:26Z

-1

Please change the code, and replace this:

   if (a.indexOf(news[i]))
            {newspaper[i].checked = true; 
   }

by:

for(j = 0; j < newspaper.length; j++){
   if(newspaper[j].value == newspaper[i].value){
      if (a.indexOf(news[i])){
         newspaper[j].checked = true;
      }
   }
}

edited Feb 23, 2015 at 1:02

Pang

10.2k146 gold badges87 silver badges126 bronze badges

answered Sep 16, 2014 at 11:48

Mudassir

5985 silver badges6 bronze badges

Collectives™ on Stack Overflow

how to check checkboxes in javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related