How to put cursor data in array?

Question

I am fetching data from database and after that assigning it to arrays in this process i always get length of all arrays as 1 only.

Method :

public void fetchData() {

    database.open();
    Cursor cursor = database.getAllData();
    cursor.moveToFirst();

    while (!(cursor.isAfterLast())) {
        nameArr = new String[] { cursor.getString(1) }; // i tried to put cursor data in arr from here
        addressArr = new String[] { cursor.getString(2) };
        contactArr = new String[]{ cursor.getString(3) };
        cursor.moveToNext();
    }

    database.close();
    Log.d("ArrayLength", Integer.toString(nameArr.length));//The arraylength is 1 i dont know why??

}

You're creating a new String array with only one element each time through the loop. — Mike M.
– Mike M., Commented Sep 19, 2014 at 4:16

ρяσѕρєя K · Accepted Answer · 2014-09-19 04:17:17Z

2

Use Cursor.getCount() outside while loop to initialize all arrays as:

 int count=cursor.getCount();
 nameArr=new String[count];
 addressArr=new String[count];
 contactArr=new String[count];
 int index_count=0;
while(!(cursor.isAfterLast())){
    nameArr[index_count]=cursor.getString(1); 
    addressArr[index_count]=cursor.getString(2);
    contactArr[index_count]=cursor.getString(3);
    index_count++;
    cursor.moveToNext();
}

To avoid use of index_count use ArrayList to store all data from cursor/

answered Sep 19, 2014 at 4:17

ρяσѕρєя K

133k54 gold badges203 silver badges216 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

shashi2459 · Accepted Answer · 2014-09-19 04:59:01Z

0

This is a very simple example...

    Cursor client = db.rawQuery(sql, null);

    String[][] clients = new String[2][client.getCount()];
    if(client.moveToFirst()){
        do{
            clients[0][i] = client.getString(client.getColumnIndex(CLIENT_NAME));
            clients[1][i++] = String.valueOf(client.getInt(client.getColumnIndex(CLIENT_ID)));
        }while (client.moveToNext());
    }
    client.close();

answered Sep 19, 2014 at 4:59

shashi2459

5811 gold badge6 silver badges15 bronze badges

Collectives™ on Stack Overflow

How to put cursor data in array?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related