If statement then click event in JavaScript

Question

I am trying to only allow a click event to fire if a function return is true. I am not sure if this is the correct syntax or not. Any help would be awesome.

onclick="if(AveryValidateAddress())Shipping.save()"

"I am not sure if this is the correct syntax or not."? Have you tried it? Did it work? Are you asking if there is a better way? — Karl-André Gagnon
– Karl-André Gagnon, Commented Sep 19, 2014 at 20:33
Yes, your syntax is correct, although not a best practice. Instead of putting code into your inline onclick handler, write a separate save function and add it via addEventListener. — Palpatim
– Palpatim, Commented Sep 19, 2014 at 20:33
FYI, addEventListener is not supported by some/all versions of Internet Explorer. — jwatts1980
– jwatts1980, Commented Sep 19, 2014 at 20:38
@Karl-AndréGagnon - I have tried it and no it did not work. I get an error telling me that AveryValidateAddress is undefined, though that is the exact name of the function it references. — Kevin Schultz
– Kevin Schultz, Commented Sep 19, 2014 at 20:50
@KevinSchultz Your function must be in a closure. Check if you function is not inside a DOM ready or any other function. — Karl-André Gagnon
– Karl-André Gagnon, Commented Sep 19, 2014 at 21:01

Cyril Duchon-Doris · Accepted Answer · 2014-09-19 20:33:59Z

4

Why would you not include the check Inside the function ?

HTML

onclick="myFunction()"

JS

myFunction = function(){
  if (!AveryValidateAddress()){
     //Dont do anything if it's false
     return
  }
  else{
      Shipping.save()
  }
}

answered Sep 19, 2014 at 20:33

Cyril Duchon-Doris

14.2k12 gold badges92 silver badges181 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Apul Gupta · Accepted Answer · 2014-09-19 20:35:29Z

0

Try:

onclick="AveryValidateAddress() && Shipping.save()"

answered Sep 19, 2014 at 20:35

Apul Gupta

3,0344 gold badges24 silver badges30 bronze badges

Comments

Brett · Accepted Answer · 2014-09-19 20:35:56Z

-1

The way you have it written, you could accomplish this by taking advantage of the && operator's lazy evaluation. If the first part of your and statement evaluates to false, it won't attempt to evaluate the second part.

onclick="AveryValidateAddress() && Shipping.save()"

However, since you're using jQuery, a better approach would be to take advantage of jQuery's event binding:

<a href="#" id="saveButton">Click to save</a>

<script>
$(document).ready(function(){
    $('#saveButton').click(function(){
       if( AveryValidateAddress() ){
          Shipping.save();
       }
    });
});
</script>

answered Sep 19, 2014 at 20:35

Brett

5893 silver badges10 bronze badges

2 Comments

Sablefoste Over a year ago

Where does it say he is using jQuery?

Brett Over a year ago

@SableFoste He had the jQuery tag on the question before it was edited

Collectives™ on Stack Overflow

If statement then click event in JavaScript

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related