char array to int in c++

Question

I am unable to get the part of the string stored in form of char array.

char code1 [12]={0};
char c;
string compressed_file;

I am taking the input from a text file, till a ',' occurs in it.

cout<<"Input compressed_file name"<<endl;
cin>>compressed_file;
string extracted_file;
cout<<"Input extracted_file name"<<endl;
cin>>extracted_file;

ifstream input;
input.open(compressed_file.c_str());
ofstream decompresscode;
decompresscode.open(extracted_file.c_str());

input>>c;
while(c != ',')
{
    int i=0;
    code1[i]=c;
    cout<<code1[i];
    i++;
    input>>c;
}
int old=atoi(code1);
cout<<old;

After printing the value of code1 here, I am only getting the first letter of the array. My code1 is 66, it is printing only 6.

Consider using an std::vector<char> instead of your array. This enables longer input and you would not need the variable i, select the back() element instead. — tgmath
– tgmath, Commented Oct 6, 2014 at 16:10

NetVipeC · Accepted Answer · 2014-10-06 16:08:56Z

5

You are always saving in the position 0:

int i=0; // this need to be out of while loop
code1[i]=c;
cout<<code1[i];

You need also to add a check for read at max 12 char (to not overflow code1). The code could be something like.

input >> c;
int i = 0;
while (c != ',' && i < sizeof(code1)) {
    code1[i] = c;
    cout << code1[i];
    i++;
    input >> c;
}

edited Oct 6, 2014 at 16:08

answered Oct 6, 2014 at 16:02

NetVipeC

4,4321 gold badge20 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

crashmstr · Accepted Answer · 2014-10-06 16:03:37Z

2

Move int i = 0 outside the loop. As it is, you are resetting it to 0 each time.

input>>c;
int i=0; //move to here
while(c != ',')
{        
    code1[i]=c;
    cout<<code1[i];
    i++;
    input>>c;
}

answered Oct 6, 2014 at 16:03

crashmstr

28.7k9 gold badges66 silver badges80 bronze badges

Collectives™ on Stack Overflow

char array to int in c++

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related