ArrayList "get(i)" command using a public class variable

Question

I am trying to get the length of the longest first name and saving it as int longest, but my code is not properly fetching the first names from my class Student

here is my code:

public static int findLongestFirstName(ArrayList<Student> studentList) 
{
    int longest = 0;
    for (int i = 0; i < studentList.size(); i++)
        {
            if (studentList.get(i).getFirstName.length() > longest);
            {
                longest = studentList.get(i).getFirstName.length();
            }
        }
    return longest;
}

Here is where I am fetching my variables:

public class Student 
{
private int IDnum;
private String firstName;
private String lastName;
private int gradYear;
private double gradePoint;
public Student(int ID, String first, String last, int year, double GPA)
{
    IDnum = ID;
    firstName = first;
    lastName = last;
    gradYear = year;
    gradePoint = GPA;
}
public int getID()
{
    return IDnum;
}
public String getFirstName()
{
    return firstName;
}
public String getLastName()
{
    return lastName;
}
public int getYear()
{
    return gradYear;
}
public double getGPA()
{
    return gradePoint;
}

}

NPE · Accepted Answer · 2014-10-09 18:06:44Z

3

getFirstName is not a variable, it's a method. Java syntax requires parentheses when calling a method (even if the method takes no arguments):

if (studentList.get(i).getFirstName().length() > longest);
                                   ^^

(and on the next line).

By the way, you can replace the entire if construct with:

longest = Math.max(studentList.get(i).getFirstName().length(), longest);

To simplify this further, you could use a for-each loop:

public static int findLongestFirstName(ArrayList<Student> studentList) 
{
    int longest = 0;
    for (Student student : studentList) {
        longest = Math.max(student.getFirstName().length(), longest);
    }
    return longest;
}

answered Oct 9, 2014 at 18:06

NPE

503k114 gold badges970 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arslan Mehboob · Accepted Answer · 2014-10-09 18:39:54Z

1

Your code seems fine however there is a semi colon at the end of your if statement which is causing the issue.

answered Oct 9, 2014 at 18:39

Arslan Mehboob

1,0301 gold badge10 silver badges21 bronze badges

Collectives™ on Stack Overflow

ArrayList "get(i)" command using a public class variable

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related