Pointer in linked list/vector

Question

I'm trying to implement my own linked list using vectors and pointers. The problem I'm have is that I can't get the first node to point to the second node.

Here's my code and what I've tried:

struct Node {
    Node* previous;
    Node* next;

    int data;
};

// Initialize: Create Vector size 20 and first node
void LinkedList::init() {
    vecList.resize(20, NULL); // Vector of size 20
    Node* head = new Node();  // Create head node
    head->previous = NULL;    // Previous point set to null
    head->next = vecList[1];  // Next pointer set to next position
    head->data = 0;           // Data set at value 0

    vecList[0] = head; // Put head node in first position
    count = 1; // Increase count by 1
}

// Add Node to array
void LinkedList::push_back(Node* node, int data) {
    count += 1;
    node = new Node();
    node->next = vecList[count + 1];
    node->previous = vecList[count - 1];
    node->data = data;
    vecList[count - 1] = node;
}

The data has been passed in and will displayed using:

cout << linkedlist.vecList[1]->data << endl;

But if I try this way to display I get error saying the next pointer is <Unable to read memory>

cout << linkedlist.vecList[0]->next->data << endl;

What is LinkedList? What is vecList? How do you use the code? What error do you get? — Some programmer dude
– Some programmer dude, Commented Oct 11, 2014 at 13:42
And if the errors are not build errors, then have you tried to step through the code line by line in a debugger? — Some programmer dude
– Some programmer dude, Commented Oct 11, 2014 at 13:43
LinkedList is the class and vecList is the vector of nodes. The error i get is "Access violation reading location 0x00000008." Went through the debugger and form what i can see the problem is my pointers are not pointing to any thing — Derek O Brien
– Derek O Brien, Commented Oct 11, 2014 at 13:47
@ilent2 this is how i call it : linkedlist.push_back(node, 64); it adds the data but pointers to next and previous point to notting — Derek O Brien
– Derek O Brien, Commented Oct 11, 2014 at 13:49

w1th0utnam3 · Accepted Answer · 2014-10-11 13:57:36Z

2

You forgot to set the next pointer of the previous Node in the push_back method. If count is a member variable of the list containing the number of entries you have to change the method like this:

EDIT: actually you have to increment count in the end because array indices start with zero.

void LinkedList::push_back(Node * node, int data){  
    node = new Node();
    node->next = NULL;  // NULL because next element does not exist yet
    node->previous = vecList[count - 1];
    node->data = data;
    vecList[count] = node;
    vecList[count-1]->next = vecList[count];
    count++;
}

Still it's a bit strange that you try to implement a linked list with a vector or array because that actually defeats the advantages of a list...

edited Oct 11, 2014 at 13:57

answered Oct 11, 2014 at 13:51

w1th0utnam3

1,0219 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Derek O Brien Over a year ago

Thank you sorted my problem :) and as for why i'm using a vector to store the list ya can ask my lecturer

wimh · Accepted Answer · 2014-10-11 13:47:04Z

2

It looks like vecList is a vector/array of pointers to Node.

When you init, you let the first element point to the second element:

void LinkedList::init(){
    ...
    head->next = vecList[1];

But at this point, the second element does not exist yet. So you cannot point to it yet. Something similar is wrong at the push_back function.

answered Oct 11, 2014 at 13:47

wimh

15.3k6 gold badges50 silver badges100 bronze badges

Collectives™ on Stack Overflow

Pointer in linked list/vector

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related