Javascript | passing string variable to onclick event not working

Question

I am trying to open a popup windows but the button's onclick content is stored in a variable. Thsi is my approach:

var page = 'window.open(\'ticket.html?wallet='+global_wallet+'\',\'popUpWindow\');';
document.getElementById('EditButton').onclick=page;

This is not working. Not popup being displayed. Something is missing and i don't figure out what is it...

Regards,

MrCode · Accepted Answer · 2014-10-12 13:11:37Z

3

The onclick property is supposed to be a JavaScript function, not a string like you are trying.

You can pass a function:

document.getElementById('EditButton').onclick = function(){
    window.open('ticket.html?wallet='+global_wallet,'popUpWindow');
};

Or if for some reason you have to use the string, you can set the onclick attribute. In this case you need to use setAttibute() instead of the onclick property.

document.getElementById('EditButton').setAttribute('onclick', page);

answered Oct 12, 2014 at 13:11

MrCode

64.6k10 gold badges95 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript | passing string variable to onclick event not working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related