My Javascript code not working properly

Question

I am creating a simple function that increment number and bind with multiple Table as S.NO.. I don't understand what's wrong with my code.

    function _IncrementNumber(id) {
        var table = document.getElementById(id);
        var rowCount = table.rows.length;
        for (var i = 0; i < rowCount; i++) {
            table.rows[i + 1].cells[0].innerHTML = (i + 1);
        }
    }
$(document).ready(function () {
    _IncrementNumber("FirstTable");
    _IncrementNumber("SecondTable");
});

DEMO Please guide me.

you start with table.rows[1], thus skipping table.rows[0]

MJVDM
– MJVDM

2014-10-14 09:44:02 +00:00
Commented Oct 14, 2014 at 9:44 — MJVDM
– MJVDM, Commented Oct 14, 2014 at 9:44

Amir Popovich · Accepted Answer · 2014-10-14 09:42:20Z

3

You are accessing i+1 instead of i.
In the last iteration -> you will go out of bounds.

function _IncrementNumber(id) {
        var table = document.getElementById(id);
        var rowCount = table.rows.length;
        for (var i = 0; i < rowCount; i++) {
            table.rows[i].cells[0].innerHTML = (i + 1);
        }
}
$(document).ready(function () {
    _IncrementNumber("FirstTable");
    _IncrementNumber("SecondTable");
});

answered Oct 14, 2014 at 9:42

Amir Popovich

30.1k9 gold badges58 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ANJYR Over a year ago

i start incremented value after table heading so i think i have to use rowCount-1 and rows[i+1]

smokiespartakus · Accepted Answer · 2014-10-14 09:46:25Z

0

You're trying to access a row that doesnt exist.

You should start with i=1 instead to skip the header row

for (var i = 1; i < rowCount; i++) {
    table.rows[i].cells[0].innerHTML = (i);
}

answered Oct 14, 2014 at 9:46

smokiespartakus

1763 silver badges14 bronze badges

Comments

Khaleel · Accepted Answer · 2014-10-14 09:48:27Z

0

the error at this line was the issue. Table rows starts from 0 index. so dont need to increment the rows index change to this table.rows[i].cells[0].innerHTML = (i + 1);

answered Oct 14, 2014 at 9:48

Khaleel

1,4113 gold badges18 silver badges36 bronze badges

Collectives™ on Stack Overflow

My Javascript code not working properly

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related