How to automatically output strings in loops

Question

So I just have a quick little issue

 int pickmeup = 0;
        while (true)
        {
        pickmeup = scanner.nextInt();
        if (pickmeup == 1)
         {System.out.println ("you entered 1");}
        if(pickmeup == 2)
         {System.out.println ("you entered 2");}
        {
            break;
        }
    System.out.println ("Invalid code");

Now when I run this code it all works fine however in regards to the strings but it seems as though the loop doesn't work all that well when I enter '3', as it doesn't return the string 'Invalid code'.

If I were to get rid of the strings after both if statements, then it works perfectly fine. What exactly am I doing wrong? Are there other ways to automatically have strings output?

Sorry, I closed the brackets on the strings, if that's what you meant. — James Walburn
– James Walburn, Commented Oct 18, 2014 at 22:37
@getlost I've edited it to reflect my actual code. I made last minute changes and changed it back and forgot to edit it correctly. — James Walburn
– James Walburn, Commented Oct 18, 2014 at 22:38
Then fix your code first. Second if if(pickmeup == 2) is currently inside of the first one, just like the line System.out.println ("Invalid code");. — Tom
– Tom, Commented Oct 18, 2014 at 22:40

Elliott Frisch · Accepted Answer · 2014-10-18 22:47:40Z

1

I believe you want to use a logical or || and an else like,

int pickmeup;
while (true) {
    pickmeup = scanner.nextInt();
    if (pickmeup == 1 || pickmeup == 2) {
        System.out.printf("you entered %d%n", pickmeup);
    } else {
        System.out.println("Invalid code");
    }
}

Alternatively, you could use an else if chain like,

int pickmeup;
while (true) {
    pickmeup = scanner.nextInt();
    if (pickmeup == 1) {
        System.out.println("you entered 1");
    } else if (pickmeup == 2) {
        System.out.println("you entered 2");
    } else {
        System.out.println("Invalid code");
    }
}

answered Oct 18, 2014 at 22:47

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

James Walburn Over a year ago

Its funny, I did try an or statement, but I had issues figuring out how to make the strings work for it. This looks promising. Thanks!

mkj · Accepted Answer · 2016-10-31 10:11:53Z

0

You could start with firstly correcting your code, you can do that in eclipse Source-Format or by pressing CTRL+SHIFT+F

For your example, I corrected as much as I understood, currently it breaks only if else is reached. Break can be modified.

public static void main(String[] args) {
    Scanner scanner = new Scanner(System.in);
    int pickmeup = 0;
    while (true){
        pickmeup = scanner.nextInt();
        if (pickmeup == 1){
            System.out.println("one");
        }
        else if (pickmeup == 2){
            System.out.println("two");
        }
        else{
            System.out.println("Invalid code");
            break;
        }
    }

edited Oct 31, 2016 at 10:11

mkj

2,8515 gold badges25 silver badges28 bronze badges

answered Oct 18, 2014 at 22:54

charen

3811 gold badge8 silver badges20 bronze badges

Collectives™ on Stack Overflow

How to automatically output strings in loops

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related