php html Fatal error: Maximum execution time of 30 seconds exceeded

Question

i feel this is going to be something stupid but i cant seem to get this to work what im trying to do is read through a file and extract all the appropriate web addresses but when i run this i get a fatal error, i get the feeling im initiating an infinate loop but i cant find it

    $contents = file_get_contents("../uploads/bookmarks.html");
$find   = 'https://www.example.net/e/';
$i = 0;
do{
    if(strpos($contents, $find)){
        $check = true;
        $contents = strstr($contents,$find);
        $temp = explode('"', $contents, 2);
        echo $temp[0];
    }else{
        $check = false;
    }
}while($check = true);

Jonathan Crowe · Accepted Answer · 2014-10-22 23:48:29Z

3

You are assigning $check = true instead of comparing the two values. Turn

while($check = true)

to

while ($check === true)

edited Oct 22, 2014 at 23:48

answered Oct 22, 2014 at 23:33

Jonathan Crowe

5,8031 gold badge20 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Bijan Over a year ago

@Sebas has a 'better' solution of just using while($check). It is less redundant.

Jonathan Kuhn Over a year ago

@Jasper Actually assignment happens before the expression is checked. Or else the old standard while($row = mysql_fetch($res)) would infinite loop.

Jasper Over a year ago

Ignore me, I've been coding JS all day.

Jasper Over a year ago

@Sebas Or for those who aren't into the whole brevity thing: while($check === true) :)

Sebas Over a year ago

On that note, I'd also change strpos($contents, $find) to something more explicit like strpos($contents, $find) !== false. I don't really like the chameleon aptitude of the php functions returns...

|

Collectives™ on Stack Overflow

php html Fatal error: Maximum execution time of 30 seconds exceeded

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related