Add php while in javascript var

Question

I want to make some charts with dxcharts. Now i have the following situation:

My SQL query is:

$sql = "SELECT
av.art_title,
SUM(CASE c.cont_status WHEN 'cold' THEN av.art_views ELSE 0 END) cold,
SUM(CASE c.cont_status WHEN 'lead' THEN av.art_views ELSE 0 END) lead,
SUM(CASE c.cont_status WHEN 'prospect' THEN av.art_views ELSE 0 END) prospect,
SUM(CASE c.cont_status WHEN 'lost' THEN av.art_views ELSE 0 END) lost
FROM article_views av
JOIN contacts c ON av.user_id = c.id
GROUP BY av.art_title";
$res = mysql_query($sql) or die (mysql_error());

I have a while loop on the query like:

while($row = mysql_fetch_assoc($res)) { }

And below i will post my javascript var:

var dataSource = [{ country: "<?php echo $row['art_title']; ?>", lead: <?php echo $row['lead']; ?>, lost: <?php echo $row['lost']; ?>}, ];

So if i use the while in the datasource var it's not working at all. Can anyone help me out here?

You're dumping text from PHP into a JS context - you're vulnerable to the JS equivalent of sql injection attacks. ALWAYS output via json_encode() so you're generating syntactically correct JS strings. — Marc B
– Marc B, Commented Oct 28, 2014 at 20:24

Steve · Accepted Answer · 2014-10-29 11:52:24Z

1

$data=array();
while ($row = mysql_fetch_assoc($res)){
    $data[]=array('country'=> $row['art_title'], 'lead'=> $row['lead'], 'lost'=> $row['lost']);
}
$json=json_encode($data);

//javascript
var dataSource=<?php echo $json; ?>;

edited Oct 29, 2014 at 11:52

answered Oct 28, 2014 at 20:46

Steve

20.5k5 gold badges47 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Brecht S Over a year ago

It's not working. I have this in my javascript: var dataSource = <?php echo $json; ?> But i don't have the brackets [ ] Is that the problem?

Steve Over a year ago

What does the generated output look like? Are you getting any js errors I the console?

Brecht S Over a year ago

The chart is not showing up. No errors so far as i can see.

Brecht S Over a year ago

Now it's working here. The var datasource has to be a ; at the end. Steve, you forgot that. Do you have experience with dxcharts? I have a wrong sorting on the argumentaxis.

Steve Over a year ago

@BrechtS Oops, yes i missed that (typing code into a smartphone is not simple!). I dont have any direct experiance with dxcharts but if you explain your issue i might be able to help

|

Oleksiy M. · Accepted Answer · 2014-10-28 21:21:16Z

0

By the way, the original MySQL extension is now deprecated http://php.net/manual/en/migration55.deprecated.php , and will generate E_DEPRECATED errors when connecting to a database. Instead, use the MySQLi (or PDO_MySQL) extensions.

The E_DEPRECATED error will not be displayed probably on the production server, but it will be generated anyway and it takes time.

So the while loop will look like:

while ( $row = $result -> fetch_array ( MYSQLI_ASSOC ) ) { ... }

If you writing a new PHP application, - use the MySQLi.

answered Oct 28, 2014 at 21:21

Oleksiy M.

1,03313 silver badges8 bronze badges

Collectives™ on Stack Overflow

Add php while in javascript var

2 Answers 2

8 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related