symfony2: dependency injection for forms

Question

Actually I'm rather confused about the best way to pass arguments to a form. As far as I know, there are three ways:

To turn the form class into a service
To pass arguments through the array options
To pass argument through the constructor of the form class

What would be the best/cleanest way?

jamek · Accepted Answer · 2014-10-31 09:31:32Z

1

In my opinion:

To turn the form class into a service - you use if arguments are available by DI, like EntityManager, Router and other services etc.
To pass arguments through the array options - "static" data like: show this field for admin only,

answered Oct 31, 2014 at 9:31

jamek

81211 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

smarber Over a year ago

So you're saying that if we need to logger for example it's only nicer to turn the form into a service. But what I think is when the form is called from a controller, it's way easier to just pass args through either the constructor or the array $options: you don't have to declare your form into your services file, you don't have to update the services file every time you realize you need another dependency etc...

jamek Over a year ago

It's just my opinion. I prefer clean code even if i have to modify service declaration. Less code in controller = less errors. Next improvement is i don't have to modify controller to change form in example: add some field. I only have to override service which is much simpler to do and don't duplicate code (controller) to do this. FormType as service in my case always are big and complicated so for me it's better solution.

smarber Over a year ago

I agree with you, as a service the form is much more standalone. +1

Cerad Over a year ago

@smarber - One problem with injecting dependencies manually in the controller is that you have to remember to do so and to get them in the correct order. If another dependency needs to be added then you to find every controller that uses that form and update your code. Finally, if you to use the form as part of a collection then you are really stuck.

George · Accepted Answer · 2014-10-30 19:49:16Z

0

For the majority of my forms, I create a separate form class. When I need to render the form with prepopulated data, I load the entity in my controller and pass that entity when construction the form. For example, if I have an entity called $user linked to registration entity, I will populate my form like this:

    $registration = $user->getRegistration();

    $form = $this->createForm(new RegistrationType(), $registration, array());

Then I render the $form in twig:

    return $this->render(
       'AcmeAccountBundle:Account:register.html.twig',
        array('form' => $form->createView())
    );

answered Oct 30, 2014 at 19:49

George

1,49917 silver badges29 bronze badges

2 Comments

Cerad Over a year ago

And how does this answer the question of passing arguments to the form?

George Over a year ago

the $registration variable is the same type that the registration form uses and this will populate the form. When you said pass arguments, I assume you meant you want the fields to be populated with specific items and this will do that.

Collectives™ on Stack Overflow

symfony2: dependency injection for forms

2 Answers 2

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related