Adding users from CSV in Linux using BASH

Question

My CSV file contains the information needed like this firstname,lastname,userid. I have 5 users which i need to parse from the CSV. In order to create the account assign to a group(group1) and assign encrypted temporary passwords. I've hit a wall, any help would be awesome. Thanks!

#!/bin/bash

OLDIFS=$IFS
IFS=","

while read firstname lastname userid 
 do 
    useradd -c "$firstname $lastname -d /home/$userid -G group1 -s /bin/bash $userid"
done
IFS=$OLDIFS

No users are being added from script execution.

@1up You have an un-closed quote. But there's no way of knowing whether that's the cause since you haven't properly described the problem. — Biffen
– Biffen, Commented Nov 4, 2014 at 13:57
Getting an Error on line 8 when I execute in BASH; ./Parse.sh: line 8: unexpected EOF while looking for matching `"' ./Parse.sh: line 12: syntax error: unexpected end of file — 1up
– 1up, Commented Nov 4, 2014 at 13:57
@1up As I said: Un-closed quote. Using an editor with syntax highlight helps. And/or shellcheck.net — Biffen
– Biffen, Commented Nov 4, 2014 at 13:58
@1up It looks like you send all your data as a comment to useradd. I think you meant to put quotes around each parameter. — Biffen
– Biffen, Commented Nov 4, 2014 at 14:10

Kannan Mohan · Accepted Answer · 2014-11-04 14:56:57Z

1

This should help you.

#!/bin/bash

OLDIFS=$IFS
IFS=","

while read firstname lastname userid 
do 
     useradd -c "${firstname} ${lastname}" -d /home/"${userid}" -G group1 -s /bin/bash "${userid}"
done < file.csv

Your script was fine, i have made few changes as below

Have quoted the variables, this will prevent unwanted expansions.
Resetting IFS is not necessary as the script runs in a subshell.
while needs a file input, so added it.

edited Nov 4, 2014 at 14:56

answered Nov 4, 2014 at 14:28

Kannan Mohan

1,85012 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

1up Over a year ago

Thanks, I had also saved my file to the wrong location, hence the no change.

Biffen Over a year ago

Regarding #4: The double quotes are enough. This way the single quotes will be sent to useradd (which may not be a problem).

Collectives™ on Stack Overflow

Adding users from CSV in Linux using BASH

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related