"java.lang.ArrayIndexOutOfBoundsException: 1" Error When Run

Question

The program compiles fine, but when I run it, I get an error, more specifically this: java.lang.ArrayIndexOutOfBoundsException: 1

It is getting the error on:

String name = array[1];

I am not sure why.

This is the code with the problem:

        infile = new Scanner(new FileReader("EmployeeData.TXT"));
        while(infile.hasNext()){
            String line = infile.nextLine();
            String array[] = line.split(":");
            String name = array[1];
            String id = array[2];
            double salary = Double.parseDouble(array[3]);
            Employee e;
            if (array[0].equals("s")){
                e = new SalariedWorker(id, name, salary);}
            else {
                boolean overtime = Boolean.parseBoolean(array[4]);
                if(overtime){
                    int maxhu = Integer.parseInt(array[5]);
                    e = new HourlyWorker(id, name, salary, maxhu);
                }
                else{
                    e = new HourlyWorker(id, name , salary);
                }
            }
            company.add(e);
        }

For reference, this is the rest of the program:

It reads this text file called "EmployeeData.TXT":

S       Washington,George       000001      125000
H   MacDonald,Ronald        386218     7.80 true  40
H       Walton,Samuel           268517  8.21    false
H   Thomas,David            131313  9.45    true    38
H   Sanders,HarlandDavid    277651  8.72    false
S   Baron,James         368535  310236

virtually all this code is unnecessary. Read up on how to make minimal, complete, verifiable examples. — Mike 'Pomax' Kamermans
– Mike 'Pomax' Kamermans, Commented Nov 5, 2014 at 21:04
The problem is the parsing of the line. You use : sign. But you don't have it in your line. And the array has only 1 element. Not two. array[1] is the second element of the array. It compiles fine, but in the runtime it breaks. — Mladen Uzelac
– Mladen Uzelac, Commented Nov 5, 2014 at 21:08
It's a skill gained through experience as to how much is enough and how much is too much. It's always good to read the tour and the help center sections to get recommendations. — Hovercraft Full Of Eels
– Hovercraft Full Of Eels, Commented Nov 5, 2014 at 21:09
That's an awful lot of writing for something that 5 minutes of debugging would have figured out. — Hot Licks
– Hot Licks, Commented Nov 5, 2014 at 21:53

Hovercraft Full Of Eels · Accepted Answer · 2014-11-05 21:03:32Z

You're splitting on ":", and your text file:

S       Washington,George       000001      125000
H   MacDonald,Ronald        386218     7.80 true  40
H       Walton,Samuel           268517  8.21    false
H   Thomas,David            131313  9.45    true    38
H   Sanders,HarlandDavid    277651  8.72    false
S   Baron,James         368535  310236

does not have any such character. So each array will have size 1.

It makes no sense to split on a non-existing character, which makes me very curious why you would choose to use ":". Myself, I'd split on white space, "\\s+"

As an aside, this problem is very amenable to debugging either with a debugger or with some printlns:

while(infile.hasNext()){
    String line = infile.nextLine();
    System.out.println("Unsplit String: " + line);
    String array[] = line.split(":");
    System.out.println("Split String: " + java.util.Arrays.toString(array));

Either way, in the future when you have similar problems, find out just what your variables are holding at the time and place of the error, and that often will lead you to the origin of the problem and thereby to its solution.

austin wernli · Accepted Answer · 2014-11-05 21:06:45Z

1

It is breaking on these lines:

    String line = infile.nextLine();
    String array[] = line.split(":");
    String name = array[1];
    String id = array[2];

You are trying to assign the value of array[1] to name... But the array doesn't contain enough elements.

So say you have line = "hey" and you call split on line, your array will only be of length 1, since there is no ":" character to split on.

answered Nov 5, 2014 at 21:06

austin wernli

1,80112 silver badges15 bronze badges

Collectives™ on Stack Overflow

"java.lang.ArrayIndexOutOfBoundsException: 1" Error When Run

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related