Lowest of array values

Question

My program is supposed to get random numbers and put them in the array. Then it's supposed to find lowest, highest, sum, and average. Everything works except the lowest function. Any help please! EDIT: posted whole program

  int main()
{
    int nums[SIZE] = { 0 };
    int smallest;
    int highest;
    int sum;
    double avg;

    putNums(nums);
    getNums(nums, SIZE);
    getLowest(nums, SIZE, smallest);
    getHighest(nums, SIZE, highest);
    getSum(nums, SIZE, sum);
    getAvg(nums, SIZE, sum, avg);
    cout << "Smallest number of array: " << nums[smallest] << endl;
    cout << " Highest number of array: " << nums[highest] << endl;
    cout << "Sum of the array: " << sum << endl;
    cout << "Average of the array: " << setprecision(2) << fixed << showpoint << avg << endl;
}
void putNums(int nums[])
{
    ofstream outFil;    // output file object
    string filNam;      // output file name
    srand(static_cast<unsigned int>(time(0))); // seed random number generator  
    int num;            // random number to be generated
    int cnt = 1;        // count of random numbers

    cout << "To generates a file of " << SIZE << " random numbers\n";
    cout << " enter your output file name: ";   // "nums.txt"
    cin >> filNam;
    outFil.open(filNam.c_str());
    if (outFil) {
        for (int k = 0; k < SIZE; ++k) {    // generate and write numbers 
            num = MIN + rand() % MAX;       // generate random number
            cout << cnt << ". " << num << endl;
            outFil << num << endl;
            nums[cnt] = num;
            ++cnt;                          // increment count of numbers
        } // endfor
    }
    else {
        cout << "Open error on file " << filNam << endl;
        exit(1);
    } // endif
    outFil.close();        // close the file
    cout << "\n -- Done - file closed! --\n\n";
}
void getNums(int nums[], int SIZE)
{
    cout << "Your " << SIZE << " number(s) are listed: \n";
    for (int cnt = 1; cnt <= SIZE; cnt++){
        cout << nums[cnt] << endl;
    }
}
int getLowest(int nums[], int size, int & smallest)
{
    smallest = 0;
    int lowest = nums[0];
    for (int cnt = 0; cnt <= SIZE; ++cnt){
        if (nums[cnt] < lowest){
            lowest = nums[cnt];
            smallest = cnt;
        }
    }
    return smallest;
}
int getHighest(int nums[], int SIZE, int & highest)
{
    highest = 0;
    int largest = nums[0];
    for (int cnt = 0; cnt < SIZE; ++cnt){
        if (nums[cnt] > largest){
            largest = nums[cnt];
            highest = cnt;
        }
    }
    return highest;
}
int getSum(int nums[], int size, int & sum)
{
    sum = 0;
    for (int cnt = 0; cnt < SIZE; ++cnt){
        sum += (nums[cnt]);
    }
    return sum;
}
double getAvg(int nums[], int size, int sum, double & avg)
{
    avg = 0;
    avg = static_cast<double>(sum) / SIZE;
    return avg;
}

Your API is odd. Why don't you just return the index of the least value. — Kijewski
– Kijewski, Commented Nov 8, 2014 at 22:24

Orel Eraki · Accepted Answer · 2014-11-08 22:25:17Z

1

You should return the lowest variable and not smallest due the fact that smallest represents the index and lowest the value.

It should be:

return lowest;

answered Nov 8, 2014 at 22:25

Orel Eraki

12.2k4 gold badges31 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Mark Giaconia Over a year ago

unless he's trying to return the index of the lowest... not sure

Simon Over a year ago

smallest (i.e. the index) is already being returned as a reference parameter.

Orel Eraki Over a year ago

@markg, He is saying his got a problem with the function, so it is a battle between 2 possible values, he already returning the index, than it leaving us with value, but I got your point.

Mark Giaconia Over a year ago

@OrelEraki... yes, and if it's the index, he needs to stop +1 in the loop...I was just adding to your answer, not dibuting its validity

Orel Eraki Over a year ago

Also stark gave a good answer, he starts with 0 but iterate until <= SIZE he should iterate until < SIZE.

|

Maikel Luis · Accepted Answer · 2014-11-09 00:33:10Z

The source code is generally good but has conceptual and technical errors, here I send you a solution running

#include <iostream>
#include <fstream>

using namespace std;

#define SIZE 500
#define MIN 1
#define MAX 10000


void putNums(int *nums)
{
    ofstream outFil;    // output file object
    string filNam;      // output file name
    srand(static_cast<unsigned int>(time(0))); // seed random number generator
    int num;            // random number to be generated

    cout << "To generates a file of " << SIZE << " random numbers\n";
    cout << " enter your output file name: ";   // "nums.txt"
    cin >> filNam;
    outFil.open(filNam.c_str());
    if (outFil) {
        for (int k = 0; k < SIZE; k++) {    // generate and write numbers
            num = MIN + rand() % MAX;       // generate random number
            cout << (k + 1) << ". " << num << endl;
            outFil << num << endl;
            nums[k] = num;
        } // endfor
    }
    else {
        cout << "Open error on file " << filNam << endl;
        exit(1);
    } // endif
    outFil.close();        // close the file
    cout << "\n -- Done - file closed! --\n\n";
}
void getNums(int *nums, int size)
{
    cout << "Your " << size << " number(s) are listed: \n";
    for (int cnt = 0; cnt < size; cnt++){
        cout << nums[cnt] << endl;
    }
}
int getLowest(int *nums, int size)
{
    int lowest = nums[0];
    for (int cnt = 1; cnt < size; cnt++){
        if (nums[cnt] < lowest){
            lowest = nums[cnt];
        }
    }
    return lowest;
}
int getHighest(int *nums, int size)
{
    int largest = nums[0];
    for (int cnt = 1; cnt < size; cnt++){
        if (nums[cnt] > largest){
            largest = nums[cnt];
        }
    }
    return largest;
}
int getSum(int *nums, int size)
{
    int sum = 0;
    for (int cnt = 0; cnt < size; cnt++)
    {
        sum += nums[cnt];
    }
    return sum;
}
double getAvg(int nums[], int size, int sum)
{
    return static_cast<double>(sum) / size;
}

int main(int argc, const char * argv[])
{

    int *nums;
    int smallest;
    int highest;
    int sum;
    double avg;

    nums = (int*)malloc(sizeof(int) * SIZE);
    putNums(nums);
    getNums(nums, SIZE);
    smallest = getLowest(nums, SIZE);
    highest = getHighest(nums, SIZE);
    sum = getSum(nums, SIZE);
    avg = getAvg(nums, SIZE, sum);
    cout << "Smallest number of array: " << smallest << endl;
    cout << " Highest number of array: " << highest << endl;
    cout << "Sum of the array: " << sum << endl;
    cout << "Average of the array: " << fixed << showpoint << avg << endl;
    free(nums);
    return 0;
}

PaulMcKenzie · Accepted Answer · 2014-11-08 23:22:27Z

0

You have a memory overwrite in getLowest:

 for (int cnt = 0; cnt <= SIZE; ++cnt){

In the loop, you're accessing nums[SIZE] on the last iteration, so you're accessing the array outside of its bounds.

It should be this:

  for (int cnt = 0; cnt < SIZE; ++cnt){

answered Nov 8, 2014 at 23:22

PaulMcKenzie

35.6k4 gold badges26 silver badges49 bronze badges

Comments

user2649644 · Accepted Answer · 2014-11-08 22:29:43Z

-1

Try this

int getLowest(int nums[])
{
   int lowest = nums[0];
   for(int idx = 0; idx < SIZE; idx++)
   {
      if(nums[idx] < lowest)
         lowest = nums[idx];
   }

   return lowest;
}

I'm assuming SIZE is a constant global and you are returning the lowest, so you don't have to pass it by reference

answered Nov 8, 2014 at 22:29

user2649644

1242 gold badges2 silver badges12 bronze badges

Collectives™ on Stack Overflow

Lowest of array values

4 Answers 4

6 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

6 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related