jQuery: Replace strings with .each()

Question

I want a function that replace each li with an image. This is my code:

$(document).ready(function(){
    var tmphref;
    var tmpname;
    var str = '<a href="' + tmphref + '"><img src="http://www.somesite.com/a/' + tmpname[1] + '/avatar-small.jpg /></a>';
    $('#somediv li a').each(function(){
        tmphref = $(this).attr("href");
        tmpname = /http\:\/\/(\w+)\.somesite\.com\//.exec(tmphref);
        $(this).parent().replaceWith(str);
    });
});

The image is in this specific path: www.somesite.com/a/username/avatar-small.jpg
The code above doesn't work. Any ideas?

Thank you in advance.

YOU · Accepted Answer · 2010-04-22 06:59:23Z

4

Move

var str = '<a href="' + tmphref + '"><img src="http://www.somesite.com/a/' + tmpname[1] + '/avatar-small.jpg /></a>';

after tmphref and tmpname, like this

$('#somediv li a').each(function(){
    tmphref = $(this).attr("href");
    tmpname = /http\:\/\/(\w+)\.somesite\.com\//.exec(tmphref);
    var str = '<a href="' + tmphref + '"><img src="http://www.somesite.com/a/' + tmpname[1] + '/avatar-small.jpg /></a>';
    $(this).parent().replaceWith(str);
});

because variable str is already assigned values with undefined tmphref, and tmpname, so changing the values of tmphref and tmpname after that, wouldn't effect the variable str

And, for that case, you don't need to declare variable for tmphref and tmpname outside .each function.

edited Apr 22, 2010 at 6:59

answered Apr 22, 2010 at 6:51

YOU

124k34 gold badges191 silver badges222 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Damovisa Over a year ago

Exactly - you're setting the two variables after you're using them. :)

Warrantica Over a year ago

That came into my mind, but isn't that declaring a new variable for every li? (it has the var keyword)

YOU Over a year ago

Warrantica, your tmphref is based on the each loop, so its needed to do it inside.

Collectives™ on Stack Overflow

jQuery: Replace strings with .each()

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related