Recursion Problem in PHP

Question

I need to create a valid xml from a given array();

My Method looks like this,

protected function array2Xml($array)
    {
        $xml = "";

        if(is_array($array))
        {
            foreach($array as $key=>$value)
            {
                $xml .= "<$key>";

                if(is_array($value))
                {
                    $xml .= $this->array2Xml($value);
                }
                $xml .= "</$key>";
            }

            return $xml;
        }
        else
        {
            throw new Exception("in valid");
        }
    }


protected function createValidXMLfromArray($array,$node)
    {
        $xml = '<?xml version="1.0" encoding="ISO-8859-1"?>';

        $xmlArray = $this->array2Xml($array);

        $xml .= "<$node>$xmlArray</$node>";
        return $xml;
    }

if i execute the above i just get keys with empty values;

like

<node>
<name></name>
</node>

What i need is if i pass this array("name"=>"test","value"=>array("test1"=>33,"test2"=>40));

that it return this

<node>
<name>test</name>
<value>
<test1>33</test1>
<test2>40</test2>
</value>
</node>

Where is the error what did i wrong in the above recursion?

Just a note: I recommend creating XML using the DOM Classes php.net/manual/en/book.dom.php — user253984
– user253984, Commented Apr 22, 2010 at 13:42
Check out my answer to stackoverflow.com/questions/2207599/… — Gordon
– Gordon, Commented Apr 22, 2010 at 13:45

nickf · Accepted Answer · 2010-04-22 13:36:50Z

5

You forgot the "else":

 if(is_array($value)) {
      $xml .= $this->array2Xml($value);
 } else {
      $xml .= $value;
 }

answered Apr 22, 2010 at 13:36

nickf

548k199 gold badges660 silver badges727 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

streetparade Over a year ago

I dont know why but i get epty nodes

nickf Over a year ago

@streetparade: how is this any different to dereleased's answer which worked?

Dereleased · Accepted Answer · 2010-04-22 13:38:48Z

3

You never placed the values into the code; your recursion is OK, you just missed the all-important step of supplying the data. Try this on for size:

protected function array2Xml($array)
    {
        $xml = "";

        if(is_array($array))
        {
            foreach($array as $key=>$value)
            {
                $xml .= "<$key>";

                if(is_array($value))
                {
                    $xml .= $this->array2Xml($value);
                }
                else {
                    $xml .= $value;
                }
                $xml .= "</$key>\n";
            }

            return $xml;
        }
        else
        {
            throw new Exception("in valid");
        }
    }

answered Apr 22, 2010 at 13:38

Dereleased

10.1k3 gold badges39 silver badges51 bronze badges

Comments

Tower · Accepted Answer · 2010-04-22 13:37:56Z

2

Maybe

if(is_array($value))
{
 $xml .= $this->array2Xml($value);
}
else
{
 $xml .= $value;
}

?

answered Apr 22, 2010 at 13:37

Tower

103k132 gold badges366 silver badges523 bronze badges

Comments

Senad Meškin · Accepted Answer · 2010-04-22 13:41:05Z

1

you are missing one thing, after your check if $value is array you need to add else else $xml .= $value;

if you know what I mean

answered Apr 22, 2010 at 13:41

Senad Meškin

13.8k4 gold badges39 silver badges55 bronze badges

Collectives™ on Stack Overflow

Recursion Problem in PHP

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related