IF ELSE syntax error

Question

My IF..ELSE block fails at BEGIN. I can understand how my expression is not boolean in nature, but what is causing this failure?

IF (SUBSTRING(@PARIDIN,1,1) = 'P' 
BEGIN
  SET @PARIDTEMP = SUBSTRING(LTRIM(RTRIM(@PARIDIN)),2,6))
END
BEGIN
  ELSE SET @PARIDTEMP = @PARIDIN
END

ALL CAPS IS SOOO MUCH FUN! But you should stop that right now - it's really hard to read, really annoying - and it's considered SHOUTING at people which is rude and unwelcome. Please don't do it. — marc_s
– marc_s, Commented Nov 13, 2014 at 21:55

ps2goat · Accepted Answer · 2014-11-13 22:30:49Z

2

You have an extra set of parentheses in a weird place.:

IF SUBSTRING(@PARIDIN,1,1) = 'P' -- one at the beginning of this line.
 BEGIN
  SET @PARIDTEMP = SUBSTRING(LTRIM(RTRIM(@PARIDIN)),2,6) -- one at the end of this line.
 END
ELSE
 BEGIN
  SET @PARIDTEMP = @PARIDIN
 END

edited Nov 13, 2014 at 22:30

answered Nov 13, 2014 at 21:49

ps2goat

8,5251 gold badge39 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ps2goat Over a year ago

Due to what @Sean Lange mentioned, I moved the ELSE outside of the BEGIN and END block.

Ross Bush · Accepted Answer · 2014-11-13 21:49:30Z

1

You are not closing the expression being evaluated.

Change

IF (SUBSTRING(@PARIDIN,1,1) = 'P'

To

IF (SUBSTRING(@PARIDIN,1,1) = 'P')

answered Nov 13, 2014 at 21:49

Ross Bush

15.2k2 gold badges39 silver badges65 bronze badges

Comments

Sean Lange · Accepted Answer · 2014-11-13 22:20:38Z

0

Taking everybody else's suggestion of fixing the condition I am surprised nobody mentioned the very strange BEGIN END blocks. They don't make sense and not sure they would even work. Since you have only a single statement for each it makes more sense to remove them.

IF (SUBSTRING(@PARIDIN,1,1) = 'P')
  SET @PARIDTEMP = SUBSTRING(LTRIM(RTRIM(@PARIDIN)),2,6))
ELSE 
    SET @PARIDTEMP = @PARIDIN

answered Nov 13, 2014 at 22:20

Sean Lange

33.7k3 gold badges28 silver badges42 bronze badges

3 Comments

ps2goat Over a year ago

BEGIN and END are not strange. They are there for a reason. They allow you to execute multiple statements inside of the IF or ELSE blocks. IMO, it is better to have this construct before others modify the code, so we don't end up with unexpected results (thought and ELSE block would cause a syntax error without a valid IF block before it. Though I do see the incorrectly placed ELSE as a problem.

Sean Lange Over a year ago

I fully understand the point, I was stating the structure of the way the OP had them was quite strange. The else was inside the BEGIN. Sorry you misunderstood my comment I should have been more clear.

Anthony Over a year ago

Thank you Sean, that was indeed very helpful

Collectives™ on Stack Overflow

IF ELSE syntax error

3 Answers 3

1 Comment

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related