Java Code formatting for statment

Question

Is their a better way to format this for-loop?

The user enters two integers which are initialised to x and y the program prints these values out as + for the first number and - for the second number.

FOR EXAMPLE 9 and 5 would result in

+++++++++-----

I tried using a nested for-loop, but this resulted in

+-----+-----+-----+-----+-----+-----+-----+-----+-----

    Scanner sc = new Scanner(System.in);
    int x,y,total = 0;

    System.out.println("Enter two numbers greater than 0 and no greater than 20!");
    x = sc.nextInt();
    y = sc.nextInt();

    draw(x,y);  

    private static void draw(int x, int y) {
    for(int i=1; i<=x; i++)
    {
        System.out.print("+");

    }
    for(int j=1; j<=y; j++)
    {
        System.out.print("-");
    }
}

It's for a University assignment where the first number inputted is printed out as plusses and the second number is printed as minuses. The code so far does as i wish. I'm just looking how to improve it, because nobody's code is perfect, right!? — Graham Warrender
– Graham Warrender, Commented Nov 18, 2014 at 19:34

Ruslan Ostafiichuk · Accepted Answer · 2014-11-19 09:40:11Z

1

If you want to make it smaller :)

private static void draw(int x, int y) {
    for (int i = -x; i < y; i++) {
        System.out.print(i<0 ? "+" : "-");
    }
}

edited Nov 19, 2014 at 9:40

answered Nov 18, 2014 at 19:19

Ruslan Ostafiichuk

4,7427 gold badges32 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Semih Eker Over a year ago

Place of "+","-" is reverse :) Result for x = 5, y=4 is -----++++

Graham Warrender Over a year ago

What actually is ? in Java.

Ruslan Ostafiichuk Over a year ago

@GrahamWarrender It's ternary operator ?:

Mohammad Najar · Accepted Answer · 2014-11-18 19:16:55Z

1

public class MainClass {

    public static void main(String[] args) {

        Scanner sc = new Scanner(System.in);
        int x, y, total = 0;

        System.out.println("Enter two numbers greater than 0 and no greater than 20!");
        x = sc.nextInt();
        y = sc.nextInt();

        draw(x, y);
    }

    private static void draw(int x, int y) {
        for (int i = 1; i <= x; i++) {
            System.out.print("+");

        }
        for (int j = 1; j <= y; j++) {
            System.out.print("-");
        }
    }

}

Enter two numbers greater than 0 and no greater than 20!

9   --> Hit enter.
5   --> Hit enter again!
+++++++++-----

answered Nov 18, 2014 at 19:16

Mohammad Najar

1,9992 gold badges22 silver badges31 bronze badges

1 Comment

Semih Eker Over a year ago

Is ıt same with Graham Warrender's code in question?

Isaac · Accepted Answer · 2014-11-23 03:39:47Z

1

I would get rid of the loops all together, and use StringUtils.

private static void draw(int x, int y) {
    System.out.print(Stringutils.repeat("+", x));
    System.out.println(StringUtils.repeat("-", y));
}

edited Nov 23, 2014 at 3:39

answered Nov 18, 2014 at 19:29

Isaac

2,7214 gold badges34 silver badges48 bronze badges

1 Comment

Ruslan Ostafiichuk Over a year ago

You forgot to print it: System.out.print(StringUtils.repeat("+", x) + StringUtils.repeat("y", x));

Collectives™ on Stack Overflow

Java Code formatting for statment

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related