Symfony Console ContainerAwareCommand $this->getContainer() produces Fatal error

Question

TL;DR

I'm creating console Garbage collector, which should be able to get services from container. It's basic, almost straight from the manual:

<?php
namespace SomeBundle\Console\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand,
    Symfony\Component\Console\Input\InputArgument,
    Symfony\Component\Console\Input\InputInterface,
    Symfony\Component\Console\Input\InputOption,
    Symfony\Component\Console\Output\OutputInterface;

class GarbageCollector extends ContainerAwareCommand
{
    protected function configure()
    {
        $this
            ->setName('garbage:collect')
            ->setDescription('Collect garbage')
            ->addArgument(
                'task',
                InputArgument::REQUIRED,
                'What task to execute?'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $task = $input->getArgument('task');

        //...

        $_container = $this->getContainer();
    }
}

Then I'm trying to call it from console via application.php:

#!/usr/bin/env php
<?php
// application.php

require_once __DIR__.'/../vendor/autoload.php';

use SomeBundle\Console\Command\GarbageCollector;
use Symfony\Bundle\FrameworkBundle\Console\Application;

$application = new Application();
$application->add(new GarbageCollector);
$application->run();

Which produces fatal error:

Argument 1 passed to Symfony\Bundle\FrameworkBundle\Console\Application::__construct() must implement interface Symfony\Component\HttpKernel\Kernel Interface, none given

Manual says that only thing I need to do is to extend my class with ContainerAwareCommand, but something missing. I've wrote some crap code to pass Kernel to the Application():

#!/usr/bin/env php
<?php
// application.php

require_once __DIR__.'/../vendor/autoload.php';
require_once __DIR__.'/AppKernel.php';

use SomeBundle\Console\Command\GarbageCollector;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Input\ArgvInput;

$input = new ArgvInput();
$env = $input->getParameterOption(array('--env', '-e'), getenv('SYMFONY_ENV') ?: 'dev');
$debug = getenv('SYMFONY_DEBUG') !== '0' && !$input->hasParameterOption(array('--no-debug', '')) && $env !== 'prod';

$kernel = new AppKernel($env, $debug);
$application = new Application($kernel);
$application->add(new GarbageCollector);
$application->run();

And it works, but feels disgusting.

What do I need to make ContainerAwareCommand implementation of console app? Thanks in advance.

Ghassan Idriss · Accepted Answer · 2014-11-20 19:23:41Z

4

Symfony2 provides via its console runner the ability to call your custom commands and it will handle the injection of the service container. All you need to do is create your command in a registered bundle and it will automatically become available to you. You are initializing your command outside of the framework that is why the container is not available to you unless you manually inject it.

You can reference the cookbook here:

http://symfony.com/doc/current/cookbook/console/console_command.html

You can get a list of all the commands available by running:

php app/console

On a side note, why are you creating a garbage collector in/for PHP? Just curious because to my understanding memory is freed for you after script execution has ended.

answered Nov 20, 2014 at 19:23

Ghassan Idriss

2,11820 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Damaged Organic Over a year ago

Ah, I can see clearly now : ) I thought that it's more complicated than that. Thanks!

Damaged Organic Over a year ago

I need it for e-shop, where acquiring procedure includes kind of constructor. User can customize appearance of a product with his/her own images, so, I need to store them before checkout - and if user adds few images and then just goes away - I have a bunch of garbage. As $_FILES dumped right after script ends, those images should be physically saved to temporary location, and so, I need a custom garbage collector.

Ghassan Idriss Over a year ago

Oh, ok makes sense now :p

Francisco Luz · Accepted Answer · 2018-11-23 06:41:36Z

As by version 4.1 you can inject the container service at the constructor.

namespace App\Commands;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

class MyCommand extends Command {
    protected $container;

    public function __construct(ContainerInterface $container) {
        $this->container = $container;
        parent::__construct();
    }


    protected function configure() {
        // ...
    }

    protected function execute(InputInterface $input, OutputInterface $output) {
        // You must make Some\Service\Class public.
        // Documentation at https://symfony.com/doc/current/service_container.html#public-versus-private-services
        $some_service = $this->container->get('Some\Service\Class');
    }
}

Collectives™ on Stack Overflow

Symfony Console ContainerAwareCommand $this->getContainer() produces Fatal error

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related