Debug assertion fail from initializing an array of a class by user input

Question

I have a debug assertion that fails when running Dinner.Init(Baskets,Bags);

The error message is vector subscript out of range.

I think it has something to do with the initialization of the variable sized arrays. It takes an unusually long time at the step Dinner(int num): Apple(num){ }.

Are the error message and delay related? Is there a solution for both?

In foo.h

#include <vector>
extern int num1
extern int num2
#define Baskets = num1+num2
#define Bags = num1*2
struct  AppleStruct
{
    std::vector<int> Chunks;
    AppleStruct(){}
    AppleStruct(int num):Chunks(num){ }
};
Class Dinner
{
  std::vector<AppleStruct> Apple;
  public:
  Dinner(){}
  Dinner(int num): Apple(num){ }
  void Init(int num1, int num2);
}

void Dinner::Init(int num1, int num2)
{
int i, j;

    for (i=0; i<num1; i++)          // Fill everything INVALIDs
    {
        for (j=0; j<num2; j++)
        {
            Apple[i].Chunks[j]=1;
        }
    }
}

In foo.cpp

#include "foo.h"
int num1;
int num2;
int main(int argc, char *argv[])
{
    sscanf_s(argv[1],"%d",&num1);
    sscanf_s(argv[2],"%d",&num2);
    AppleStruct(Bags);
    Dinner(Baskets);
    Dinner.Init(Baskets,Bags);
    return 0;
}

Your code is not valid C++ and does not compile.

R Samuel Klatchko
– R Samuel Klatchko

2014-11-26 22:07:05 +00:00
Commented Nov 26, 2014 at 22:07 — R Samuel Klatchko
– R Samuel Klatchko, Commented Nov 26, 2014 at 22:07
What's wrong with it?

goosli
– goosli

2014-11-26 22:08:41 +00:00
Commented Nov 26, 2014 at 22:08 — goosli
– goosli, Commented Nov 26, 2014 at 22:08

Gaurav Sehgal · Accepted Answer · 2014-11-26 22:18:51Z

0

In the for loop ,you are assigning values to the vector chunk but you have not allocated space for a structure to hold the chunk vector.

 for (i=0; i<num1; i++)          // Fill everything INVALIDs
{
    struct AppleStruct newstruct;
    for (j=0; j<num2; j++)
    {
        newstruct.Chunks.push_back(1);
    }
    Apple.push_back(newstruct);
}

answered Nov 26, 2014 at 22:18

Gaurav Sehgal

7,4972 gold badges20 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

goosli Over a year ago

Thanks a lot! This takes a long time. Is it normal?

Matt · Accepted Answer · 2014-11-26 21:58:31Z

0

Vector is not a regular array, you should push_back to add element first. change:

Apple[i].Chunks[j] = 1;

to

Apple[i].Chunks[j].push_back(1);

Also, you need add element to Apple too.

answered Nov 26, 2014 at 21:58

Matt

6,06027 silver badges37 bronze badges

1 Comment

goosli Over a year ago

I tried this, but got an red line under Apple, and the error is std::vec<AppleStruct,std::allocator<AppleStruct>> Dinner::Apple, Error: expression must have class type. Why did this happen? Thanks a lot!

Collectives™ on Stack Overflow

Debug assertion fail from initializing an array of a class by user input

2 Answers 2

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related