How do I use the return statement with strings? - Python

Question

I am unsure as to why the following doesn't work:

def main():
    userInputs()
    print(firstColour)

def userInputs():
    validColours = ['red', 'green', 'blue', 'yellow', 'magenta','cyan']
    while True:
        firstColour = input('Enter the 1st colour: ')
        secondColour = input('Enter the 2nd colour: ')
        thirdColour = input('Enter the 3rd colour: ')
        fourthColour = input('Enter the 4th colour: ')
        if firstColour in validColours:
             if secondColour in validColours:
                if thirdColour in validColours:
                    if fourthColour in validColours:
                        break
        else:
            print('Invalid colours.Enter the colours again between red, green, blue, yellow, magenta, cyan')
        return firstColour, secondColour, thirdColour, fourthColour

I thought that if i called the main function, It would print whatever I entered as the firstColour?

i need it to print without having to use print in my userInput function since I'm planning to use it for something else. I've just simplified my problem on here — Konan
– Konan, Commented Dec 2, 2014 at 16:49
The function is returning a value, you just aren't capturing it! — thekaveman
– thekaveman, Commented Dec 2, 2014 at 16:51
Also you need to outdent the return statement. Right now you've got it inside the while when you mean to have it after the while termiantes. — Duncan
– Duncan, Commented Dec 2, 2014 at 16:52

beiller · Accepted Answer · 2014-12-02 16:51:11Z

If you want to print your first colour, try the following:

def main():
    firstColour, secondColour, thirdColour, fourthColour = userInputs()
    print(firstColour)

When you return multiple values in python in a function, it packs them into whats called a "tuple" which is a list of values put simply. You have to "unpack" them in order to use them.

There is also what appears to be a logic error in your userInputs function. Your return function is indented too far which makes it always return after the first attempt, instead of retrying.

def userInputs():
    validColours = ['red', 'green', 'blue', 'yellow', 'magenta','cyan']
    while True:
        firstColour = input('Enter the 1st colour: ')
        secondColour = input('Enter the 2nd colour: ')
        thirdColour = input('Enter the 3rd colour: ')
        fourthColour = input('Enter the 4th colour: ')
        if firstColour in validColours:
             if secondColour in validColours:
                if thirdColour in validColours:
                    if fourthColour in validColours:
                        break
        else:
            print('Invalid colours.Enter the colours again between red, green, blue, yellow, magenta, cyan')
    return firstColour, secondColour, thirdColour, fourthColour

Frank V · Accepted Answer · 2014-12-02 16:48:29Z

0

In python, you are returning what is called a tuple. If you just want to return firstColour, you'd just need adjust your logic to assign foundColour with the last found colour and then return foundColour

More info on tuples: https://docs.python.org/2/tutorial/datastructures.html#tuples-and-sequences

answered Dec 2, 2014 at 16:48

Frank V

25.5k36 gold badges109 silver badges145 bronze badges

Comments

Andy · Accepted Answer · 2014-12-02 16:51:28Z

0

You aren't utilizing the values that you return:

return firstColour, secondColour, thirdColour, fourthColour

You are returning 4 variables, but not using them

userInputs()

Replace the above with something like this:

firstColour, secondColour, thirdColour, fourthColour = userInputs()

answered Dec 2, 2014 at 16:51

Andy♦

50.8k62 gold badges181 silver badges240 bronze badges

Collectives™ on Stack Overflow

How do I use the return statement with strings? - Python

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related