jquery not running when linked to an external js

Question

Whenever I put the script in another file in the same folder as script.js, it doesn't run. It only runs when I include my code in the script tag.

I tried it out with this simple jquery code. Whenever the third script tag is uncommented, it works, but the set up I have right now doesn't run.

HTML

<!DOCTYPE html>
<html>
<head>
    <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
    <script type="text/javascript" scr="script.js"></script> // <!-- doesn't run -->
    <!--script> // <!-- only runs inside the html file -->
        $(document).ready(function(){
            $('p').click(function(){
                $(this).hide();
            });
        });
    </script-->
</head>
<body>
    <p>Click to hide.</p>
</body>
</html>

script.js

$(document).ready(function(){
    $('p').click(function(){
        $(this).hide();
    });
});

Does anyone know what I am doing wrong?

Quentin · Accepted Answer · 2014-12-06 22:30:43Z

5

scr is not src. Use a validator to make sure you haven't misspelt attribute names.

answered Dec 6, 2014 at 22:30

community wiki

Quentin

Sign up to request clarification or add additional context in comments.

1 Comment

Bob Brown Over a year ago

Right. Any time you write or revise HTML, do this: validator.w3.org It will save you hours of time.

risingPhoenix1979 · Accepted Answer · 2014-12-06 22:46:29Z

-1

Your jQuery code is being duplicated inside the script.js file and .html file so that's why the code won't run.

Remove the jQuery code from the .html file and your code will run. Also like was mention above replace scr with src in your .html file.

Finally, I'd replace the code in your script.js file with the new code listed below as click(function(){} is older code:

$(document).ready(function(){
    $("p").on("click", function(){
        $(this).hide();
    });
});

answered Dec 6, 2014 at 22:46

risingPhoenix1979

1,1741 gold badge10 silver badges22 bronze badges

Collectives™ on Stack Overflow

jquery not running when linked to an external js

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related