I'm trying to figure out why my function $ is not displaying the location of my link:
<html>
<head>
<title>Link Test</title>
</head>
<body>
<a id="mylink" href="hxxp://mysite.com">Click me</a><br>
<script>
$('mylink').href
function $(id)
{
return document.getElementById(id)
}
</script>
</body>
</html>
here is your code modified to output the href value in three different ways, pick which ever you like.
<html>
<head>
<title>Link Test</title>
</head>
<body>
<a id="mylink" href="hxxp://mysite.com">Click me</a><br>
<span id="out"></span>
<script>
console.log($('mylink').href);
document.getElementById('out').innerHTML=$('mylink').href;
alert($('mylink').href);
function $(id)
{
return document.getElementById(id)
}
</script>
</body>
</html>however I am pretty sure that's not your intent. I am not sure why you are using $ as your function name, nor why are you trying to output the href. Your intent is not clear, but I have a feeling you are not approaching things correctly.
You aren't doing anything with the href property.
Your code is equivalent to:
<script>
"hxxp://mysite.com";
</script>
You need to pass it to a function that will display it (such as console.log or alert).
document.write("Link Address: " + $('mylink').href) OR document.write("Link Address: " + document.getElementById(id)) ?
href property then you need to mention it. It doesn't matter if you use getElementById directly or from your wrapper function.I personally don't see anything wrong with your code... Though it may not be perfect and fit all the standards, it seems fine to me. If you just want to output it or something, because it isn't doing anything now, use the following code:
document.write("Link Address: " + $('mylink').href)
Here is an example.
