Mongoose + Node.js : Async issue

Question

I have a bunch of profiles in my ReadyForReview collection. Each profile contains a 'user_id_to_review' field. I want to use user_id_to_review to append the user's information from the Users collection to each profile.

// looking for all ReadyForReview profiles
ReadyForReview.find()
.exec(function(err, profilesReadyForReview) {
    var profilesReadyForReviewArray = [] //array that will be populated with profiles and user info

    // for each profile, figure out what the info for the user is from user table
    for (var i = 0; i < profilesReadyForReview.length; i++) {
        var thisUserProfile = profilesReadyForReview[i].user_id_to_review.toObjectId() // create objectID version of user_id_to_review
        User.find({
                '_id': thisUserProfile
            })
            .exec(function(err, user_whose_profile_it_is) {
                profilesReadyForReviewArray.push({
                    profile: profilesReadyForReview[i],
                    user: user_whose_profile_it_is
                })
            })
        console.dir(profilesReadyforReviewArray) // should be an array of profiles and user info
    }

})

However, i in the User.find function is wrong due to async. How can I achieve an array of profiles and user information?

Will Shaver · Accepted Answer · 2014-12-24 18:29:02Z

1

Use the async library to do your loops. https://github.com/caolan/async

// looking for all ReadyForReview profiles
ReadyForReview.find()
.exec(function(err, profilesReadyForReview) {
    var profilesReadyForReviewArray = [] //array that will be populated with profiles and user info

    // for each profile, figure out what the info for the user is from user table
    async.each(profilesprofilesReadyForReview, function(profile, done) {
        var profileId = profile.user_id_to_review.toObjectId() // create objectID version of user_id_to_review
        User.find({
                '_id': profileId
            })
            .exec(function(err, user_whose_profile_it_is) {
                profilesReadyForReviewArray.push({
                    profile: profile,
                    user: user_whose_profile_it_is
                })
                done();
            });
        }, function(){
            console.dir(profilesReadyforReviewArray) // should be an array of profiles and user info
        });
});

edited Dec 24, 2014 at 18:29

answered Dec 20, 2014 at 19:57

Will Shaver

13.2k6 gold badges51 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Pointy Over a year ago

I think you're correct here but that reference to profilesReadyForReview[i] should probably be just profile

Dev Over a year ago

Works! Thanks to you both! May the code Gods shine brightly on your day.

Collectives™ on Stack Overflow

Mongoose + Node.js : Async issue

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related