PHP performance issue

Question

I am trying to get the coin data of this website: http://www.tf2wh.com.

With this script:

$name = $_POST["item"];

$url = file_get_contents("http://www.tf2wh.com/allitems");
$dom = new DOMDocument();
@$dom->loadHTML($url);
$dom->saveHTML();

$code = "";
$xpath = new DOMXPath($dom);
foreach($xpath->query('//div[contains(attribute::class, "entry qual")]') as $e ) {
    $code .= $e->nodeValue;
}
$code = substr($code,strpos($code,$name)-30,30);
$code = explode("(",$code);
$coins = "";
for($i = 0; $i < strlen($code[0]); $i++){
    if(is_numeric($code[0][$i])){
        $coins .= $code[0][$i];
    }
}
echo $coins;

It works fine but there are two problems. First, its sooo slow, the time between request and response is around 15-30 seconds. Second, sometime this error occurs:

Fatal error: Maximum execution time of 30 seconds exceeded in C:\xampp\htdocs\steammarket\getCoins.php on line 6

How can I fix this problem with the performance issue.

Have you checked whether they have an API, so you don't have to scrape the web page? — Barmar
– Barmar, Commented Dec 27, 2014 at 13:32
Did you check what line is slow? Use some profiling tool? Or print a timestamp? — Lajos Veres
– Lajos Veres, Commented Dec 27, 2014 at 13:34
@LajosVeres I don't know :), i am new in php and have no idea how i should handle this problem. — Nimmi
– Nimmi, Commented Dec 27, 2014 at 13:41

Buse Gönen · Accepted Answer · 2014-12-27 13:38:19Z

1

Connect site slow. First php code set_time_limit(0); or ini_set('max_execution_time', 300); //300 seconds = 5 minutes

<?php
set_time_limit(0);
$name = $_POST["item"];

$url = file_get_contents("http://www.tf2wh.com/allitems");
$dom = new DOMDocument();
@$dom->loadHTML($url);
$dom->saveHTML();

$code = "";
$xpath = new DOMXPath($dom);
foreach($xpath->query('//div[contains(attribute::class, "entry qual")]') as $e ) {
    $code .= $e->nodeValue;
}
$code = substr($code,strpos($code,$name)-30,30);
$code = explode("(",$code);
$coins = "";
for($i = 0; $i < strlen($code[0]); $i++){
    if(is_numeric($code[0][$i])){
        $coins .= $code[0][$i];
    }
}
echo $coins;

answered Dec 27, 2014 at 13:38

Buse Gönen

2381 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP performance issue

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related