Multiple condition filter in AngularJS

Question

I have an ng-repeat list displaying a collection of objects. I've implemented a filter that makes the list display only objects that have been inserted today. It looks like this:

<div class="row msf-row" 
     ng-repeat="record in recordlist | filter: record.date = dateJson">

This is working fantastic. My problem is that I want to show both objects recorded today, and also records that don't have the property arrival (as they might have been introduced yesterday, but they need to be marked as arrived).

I've tried this but till today at 00.00 won't know if it's correct.

<div class="row msf-row" 
     ng-repeat="record in recordlist | 
                filter: record.date = dateJson ||  
                        record.date != dateJson && !record.arrival">

Does this make sense?

JLRishe · Accepted Answer · 2014-12-28 16:22:34Z

1

When the expressions in your markup start to get this overwrought, it's time to refactor. You should define a function in your controller that carries out the check that you want:

$scope.shouldShow = function(record) {
    return record.date == dateJson ||
           (recode.date != dateJson && !record.arrival);
}

(note: this condition is redundant; you can shorten it to):

    return record.date == dateJson || !record.arrival;

Then use that in your filter:

<div class="row msf-row" ng-repeat="record in recordlist | filter:shouldShow">

This will allow you to update the logic without editing your view.

edited Dec 28, 2014 at 16:22

answered Dec 28, 2014 at 14:17

JLRishe

102k19 gold badges138 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Eric Mitjans Over a year ago

I don't get to make it work. The conditions should be, show me only records that either have today's date (dateJson) or that don't have record.arrival (record.arrival = ''), independently of date. What am I missing?

JLRishe Over a year ago

What do you mean when you say you couldn't get it to work? What result are you getting? BTW, you seem to be using = where you should be using === (or maybe ==). You know the difference between those, right?

Eric Mitjans Over a year ago

Is filtering everything out (no results). Maybe the problem is that record.arrival exists but is empty?

JLRishe Over a year ago

Could you edit your question to show your latest attempt, or put it in some place like PasteBin?

Eric Mitjans Over a year ago

Fixed it, it was a typo : )

lafolle · Accepted Answer · 2014-12-28 15:46:55Z

0

In case you're looking to create a custom filter, you can try this. Here I assume that
app = angular.module('yourModuleName', []) or app = angular.module('yourModuleName') (later, incase you've already instantiated your module before)

<div class="row msf-row" ng-repeat="record in recordlist | customFilter:dateJson">

app.filter('customFilter', function(){
    return function(records, dateJson){
        return records.filter(function(item, index, array){
            return item.date == dateJson || (item.date != dateJson && !item.arrival);
        });
   }
})

Disclaimer: I haven't tested this code.

answered Dec 28, 2014 at 15:46

lafolle

991 silver badge8 bronze badges

Collectives™ on Stack Overflow

Multiple condition filter in AngularJS

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related