Java string too long?

Question

I have the following code in Java (which worked just fine in C++ for some reason) which produces an error:

int a;
System.out.println("String length: " + input.length());
for(a = 0; ((a + 1) * 97) < input.length(); a++) {
    System.out.print("Substring at " + a + ": ");
    System.out.println(input.substring(a * 97, 97));
    //other code here...
}

Output:

String length: 340
Substring at 0: HelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHe
Substring at 1: 
Exception in thread "AWT-EventQueue-0" java.lang.StringIndexOutOfBoundsException: String index out of range: -97
//long list of "at ..." stuff
Substring at 2:

Using a string of length 200, however, the following output is produced:

String length: 200
Substring at 0: HelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHelloHe
Substring at 1:

That is it; no exceptions raised, just... nothing. What is happening here?

Dean Harding · Accepted Answer · 2010-05-06 04:12:08Z

5

The second parameter to String.substring is the last index not the length of the substring. So you want the following (I assume):

int a;
System.out.println("String length: " + input.length());
for(a = 0; ((a + 1) * 97) < input.length(); a++) {
    System.out.print("Substring at " + a + ": ");
    System.out.println(input.substring(a * 97, (a + 1) * 97));
    //other code here...
}

answered May 6, 2010 at 4:12

Dean Harding

72.9k13 gold badges151 silver badges180 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

wrongusername Over a year ago

Yes, that was it! Thank you! Things are a bit different from C++ :)

Collectives™ on Stack Overflow

Java string too long?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related