Creating Objects inside objects using a Constructor

Question

In the below code I am trying to create an object named "portfolio" inside which I want to create other objects that contain the properties "stockvalue" and "price"?

var portfolio_create = function(stock,stockvalue,price)
{
    for(i in stock)
    {
        this[stock[i]] = stock[i];
        this[stock[i]]["stockvalue"] =stockvalue[i];
        this[stock[i]]["price"]=price[i]    
    }
}

var portfolio = new portfolio_create(["ibm","tcs"],[23,34],[34,45]);

var stock_market = portfolio;


alert(portfolio["ibm"]["stockvalue"]);  // undefined

Why does the alert return "undefined" and not 23?

Thnaks in advance.

Oleksandr T. · Accepted Answer · 2015-01-10 07:57:31Z

1

var portfolio_create = function (stock, stockvalue, price) {

    for (var i = 0, len = stock.length; i < len; i++) {
        this[stock[i]] = {};

        this[stock[i]]["stockvalue"] = stockvalue[i];
        this[stock[i]]["price"]      = price[i];    
    }
}
var portfolio = new portfolio_create(["ibm", "tcs"], [23,34], [34,45]);

Don't use for..in for arrays.
this[stock[i]] = stock[i]; replace to this[stock[i]] = {};.

Example

answered Jan 10, 2015 at 7:57

Oleksandr T.

77.6k17 gold badges177 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

S. Dess · Accepted Answer · 2015-01-10 08:02:51Z

1

I think there is a little confusion here, between objects and variables.

You can create a real JavaScript class portfolio, which contain a collection of another class stock, which contain 2 variables value and price.

In your portfolio class, you can add a AddStock methode, and a GetStock.

Look at JavaScript Classes, I think you will find your hapiness.

Steeve

answered Jan 10, 2015 at 8:02

S. Dess

112 bronze badges

Comments

dec · Accepted Answer · 2015-01-10 08:16:08Z

1

And try to use libs like underscore or lodash to get rid of these for loops (each). It is much nicer and more functional.

A little bit shorter:

this[stock[i]] = { stockvalue: stockvalue[i], price: price[i] };

answered Jan 10, 2015 at 8:16

dec

5942 gold badges10 silver badges18 bronze badges

Collectives™ on Stack Overflow

Creating Objects inside objects using a Constructor

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related