Angularjs $http.get in a factory doesn't return valid JSON but a different object

Question

When I call $http.get from a factory it doesn't return the JSON object I need but a different one.

Here's my code:

var cart = angular.module('cart', []);

cart.factory('getItems',['$http', function($http){
    return{ 
        get:$http.get('index.php').
            success(function(data){
                return data;
            })
        }
}]);


cart.controller("TableCtrl", ['$scope', 'getItems', function($scope, getItems){
    console.log(getItems.get);
}]);

now this is the JSON object that it should return:

[{"id":"1","name":"Cap"},{"id":"2","name":"Coat"},{"id":"3","name":"Shoes"}]

And this is what I get when I console.log

d {$$state: Object, success: function, error: function, then: function, catch: function…}

everything runs fine if I run the $http.get inside the controller, but if I place it in a factory it just doesn't.

scniro · Accepted Answer · 2015-01-12 01:03:56Z

5

It's returning a promise, which you need to resolve

In your controller..

getItems.get().then(function(response) {
    console.log(response.data)
});

More information, see The Promise Api

Angular $q docs

edited Jan 12, 2015 at 1:03

answered Jan 12, 2015 at 0:49

scniro

17k8 gold badges67 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Kris Over a year ago

Thank you this is correct. Can you tell me please, in a nutshell, what are promises and how do they apply in this case?

scniro Over a year ago

You're welcome, and please remember to accept the answer so we can both gain a little rep @Kris

scniro Over a year ago

@Kris if this is correct why did you accept the late answer?

Danny · Accepted Answer · 2015-01-12 00:56:40Z

$http.get returns a promise not the data itself. Your current use of the success function is not going to get data back.

In your factory:

return{ get: $http.get('myurl')};

Then consuming it should be:

myFactory.get().success(response){
     var mydata = response.data; 
}

Success is just an addition to the promise. I like to just use .then like standard, unadorned promises.

When I first heard about promises, I thought it meant you could use it without having to provide any sort of callback-like code on your consuming end. That is not true, but promises are still super awesome and very powerful. The coolest thing is that you can keep a promise around, and anybody can add a .then to the promise. Whoever does will get their code executed as soon as the asynchronous request finishes, or right away if it has already finished. So promises let you not have to worry about asynchronous behavior, but you still have to use what is basically its more powerful version of callbacks.

Collectives™ on Stack Overflow

Angularjs $http.get in a factory doesn't return valid JSON but a different object

2 Answers 2

Angular $q docs

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related