ASP.NET MVC two Parameter Issue

Question

Well I want to pass two parameters using Json to the controller, where i use a query to get result....

Now I manage to pass one parameter(first one) but the second just wont work, if i did Price/4 is will work but adding /2 says 404 in console...

//Passing ID 4 and ID 3 to HomeController/Price
$(document).ready(function () {
  $("#type, #States").change(function () {
      $.getJSON('/Home/Price/4/2', function (data) {
          var items = '<option>Select a State</option>';
          $.each(data, function (i, state) {
             items += "<option value='" + state.Value + "'>" + state.Text +"</option>";
          });
          $("#Price").html(items);
      });
  });
});

//Home Controller Function

public JsonResult States(int id, int ids)
    {
        using (TalyllynContext db = new TalyllynContext())
        {
            var query = from F in db.Fares
                        join p in db.TicketPreferences on
                        F.TicketPreferenceID equals p.ID
                        where F.TicketTypeID == id &&
                        F.TicketPreferenceID == ids
                        select p;

            return Json(new SelectList(query.ToList(), "ID", "Name"),
            JsonRequestBehavior.AllowGet);
        }
    }

Any more just let me know....

Have you defined a route parameter for /Home/Price/{id}/{ids}? Or you can use $.getJSON('/Home/Price', { id: 4, ids: 2 }, function ... — user3559349
– user3559349, Commented Jan 16, 2015 at 12:12
AHHHH.... Yeah I have but your solution helped an work how it should, life saver thank you ! — levi lucas
– levi lucas, Commented Jan 16, 2015 at 12:17
Note also you do not need the extra overhead of .ToList() or creating a SelectList just use var query = from ...select p => new { Value = p.ID, Name = p.Name }); return Json(query, JsonRequestBehavior.AllowGet); — user3559349
– user3559349, Commented Jan 16, 2015 at 12:32

Community · Accepted Answer · 2017-05-23 11:57:43Z

1

You should define such behavior in the route or use the query parameters. I've improved JavaScript code with tips from Stephen Muecke.

Query parameters approach:

$(document).ready(function () {
  $("#type, #States").change(function () {
//It's better to use Url.Action helper to construct your urls,
//So that they always will be in sync with your routes
      $.getJSON('@Url.Action("Price", "Home", new {id=4, ids=2})', function (data) {              
          var price = $("#Price");
          price.append($('<option></option>').val('').text('Select a State'));
          $.each(data, function (i, state) {
             price.append($('<option></option>').val(state.value).text(state.text))                 
          });
      });
  });
});

Or as stated by Stephen Muecke:

$(document).ready(function () {
  $("#type, #States").change(function () {
      $.getJSON('@Url.Action("Price", "Home")', {id: 2, ids: 3}, function (data) {
          var price = $("#Price");
          price.append($('<option></option>').val('').text('Select a State'));
          $.each(data, function (i, state) {
             price.append($('<option></option>').val(state.value).text(state.text))                 
          });
      });
  });
});

Route approach:

routed.MapRoute("Name", "{controller}/{action}/{id}/{ids}",
new {controller = "Home", action = "Index", ids=UrlParameter.Optional});

edited May 23, 2017 at 11:57

CommunityBot

11 silver badge

answered Jan 16, 2015 at 12:15

Vsevolod Goloviznin

12.4k1 gold badge53 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user3559349 Over a year ago

Few other things to note: Don't hard code the url, use '@Url.Action("Price", "Home")'. The 'empty' option needs a value otherwise it will post back "Select a State" so use <option value>Select a State</option> or better $('#Price').append($('<option></option>').val('').text('Select a State')); and finally you probably want $('#Price').empty(); before the ajax call.

Vsevolod Goloviznin Over a year ago

Agree with your points. Though, if this code is in js file the Url.Action will not work.

user3559349 Over a year ago

In that case you pass it as a parameter to the function

Vsevolod Goloviznin Over a year ago

Yep, there're workarounds for this (we usually use data-* attributes), nice point though, I will include them in the answer

levi lucas Over a year ago

Thanks guys helped me allot and made it allot smarter !

Collectives™ on Stack Overflow

ASP.NET MVC two Parameter Issue

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related