Php function to avoid a repeating code

Question

I am using the below code to split a string. And i have to repeat code for each input $ProductsURL[x] and output $productx[]

<?php
$url = "$ProductsURL[0]";
$urls = split("http://", $url);
$product0 = array();
foreach($urls as $val){
    if(!$val) continue;
    $product0[] = "http://$val";
}
?>
<?php
$url = "$ProductsURL[1]";
$urls = split("http://", $url);
$product1 = array();
foreach($urls as $val){
    if(!$val) continue;
    $product1[] = "http://$val";
}
?>
..................

Is there a way to avoid repeating the code for each input/output needed. I need the code ~100 times

I have store in my data base the products URL`s in one string : example.com/p2http://example.com/p1 . and i split them with the above code to get $product0[1] to get the fisr product from a brand and so on... — Razvan
– Razvan, Commented Jan 20, 2015 at 22:54

zavg · Accepted Answer · 2015-01-20 22:47:52Z

1

Use simple loop. And use array variables as hashes to store data.

Also I think that you have error in the following line: $url = "$ProductsURL[$i];".

Finally it should be something like that:

$product = array();
for ($i = 0; $i < 100; $i++) {
  $url = $ProductsURL[$i];
  $urls = split("http://", $url);
  $product[$i] = array();
  foreach($urls as $val){
    if(!$val) continue;
    $product[$i][] = "http://$val";
  }
}

answered Jan 20, 2015 at 22:47

zavg

11.2k4 gold badges47 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Oleg Dubas · Accepted Answer · 2015-01-20 22:48:01Z

1

No need for a function.
All you need is an old plain foreach loop.
And maybe some knowledge how work with variable variables (http://php.net/manual/en/language.variables.variable.php)

<?php
    foreach($ProductsURL as $key=>$url)
    {
        $urls = split("http://", $url);
        ${'product'.$key} = array();
        foreach($urls as $val) if($val) ${'product'.$key} [] = "http://$val";
    }
?>

Then, to check the outcome:

print_r($product0);
print_r($product1);
print_r($product2);
....

answered Jan 20, 2015 at 22:48

Oleg Dubas

2,3481 gold badge12 silver badges24 bronze badges

3 Comments

AbraCadaver Over a year ago

I would steer them towards $product[0] instead of $product0.

Oleg Dubas Over a year ago

Me too. But this is what the OP asked for.

AbraCadaver Over a year ago

Sometimes they ask for something because they don't know of any other way.

itamar · Accepted Answer · 2015-01-20 22:45:32Z

0

$product = array();    
for ($i = 0; ; $i++) {
        if ($i > 1) {
            break;
        }
       $url = "$ProductsURL[$i]";
    $urls = split("http://", $url);

    foreach($urls as $val){
        if(!$val) continue;
        $product[$i][] = "http://$val";
    }
    }

answered Jan 20, 2015 at 22:45

itamar

3,9775 gold badges37 silver badges61 bronze badges

Comments

Carlos M. Meyer · Accepted Answer · 2015-01-20 22:53:21Z

0

You can use variables as variable names, using $$

<?php

foreach ($productURL as $key => $value) {
$newName = 'product' . $key;
$$newName[] = $value;
}
?>

answered Jan 20, 2015 at 22:53

Carlos M. Meyer

4463 silver badges9 bronze badges

Comments

Gabriel Lupu · Accepted Answer · 2015-01-20 22:53:25Z

0

Instead of that, I would choose to store all the products in an array instead of separate variables. The code you'd need should be something like:

<?php
$products = array();
foreach ($ProductsURL as $productUrl) {
    $product = array();
    $urls = split("http://", $url);
    foreach($urls as $val){
        if(!$val) continue;
        $product[] = "http://$val";
    }
    $products[] = $product;
}
?>

answered Jan 20, 2015 at 22:53

Gabriel Lupu

1,8391 gold badge15 silver badges16 bronze badges

Collectives™ on Stack Overflow

Php function to avoid a repeating code

5 Answers 5

Comments

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related