php $string memory leak

Question

On like 20 I keep getting a memory leak. I'm sure I'm just not seeing what the problem is but was hoping someone with fresh eyes could tell me where I'm going wrong at.

--inside of the work, suppose to take a sentence and after every word with a comma, reverse the word without moving it's place in the sentence.

function bassAckwards($input)
{
  //$inputLen = strlen($input);
  $stringEnd = 0;
  $findme = ',';
  $flag1 = true;
  $tempOffset = 0;
  $string = "";

  //Start loop, as long as flag is true
  while($flag1 == true){
    //find position of next ","
    $pos = strpos($input, $findme, $tempOffset);

    //If $pos is null end loop and return string.
    if($pos == false){
      $flag1 = false;
    }
    else{
      //$pos is not null so create inner loop and add to string
      for($reverse = $pos--; $reverse > $stringEnd; $reverse--){  
        $string = $string . substr($input, $reverse); // < ------  TempStr will add in substr, which will be added to $string  
      }
    }
    $stringEnd = $pos;
    $tempOffset = $pos + 1;
  }
  return $string;
}

print bassAckwards("Php,Cookies,Arrays,Mysql,LAMP");

When I ran the code it popped a memory leak error before crashing basically. Someone pointed out the error which was in the for loop $pos-- — FubarP
– FubarP, Commented Jan 21, 2015 at 3:55

Hieu Vo · Accepted Answer · 2015-01-21 03:00:48Z

1

Your code is very bad in term of performance, try this

function bassAckwards($input)
{
    $findme = ',';
    $input = explode($findme, $input);
    foreach ($input as $i => $word) {
        $input[$i] = strrev($word);
    }
    return implode($findme, $input);
}

print bassAckwards("Php,Cookies,Arrays,Mysql,LAMP");

answered Jan 21, 2015 at 3:00

Hieu Vo

3,3441 gold badge33 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

FubarP Over a year ago

I'm still learning php and didn't realize explode did that. Came across it earlier in my studies as I was trying to find a delimiter. Didn't realize that it turned it into an array. But no idea what => $word is actually doing. I don't really see it as a operator and when I find it in the arrays it's looks like a key. Is it basically taking the words and combining them into an actual array to be used?

Misunderstood Over a year ago

@Hieu Vo I like this code. Had I seen it before I wrote mine I would not have bothered. I did not know about strrev(). Good to know.

FubarP Over a year ago

Also I edited though I doubt it would improve it since it's just 1 line and variable. Since I know I'm dealing with Commas I just deleted the $findme and replaced them all with ","

Misunderstood · Accepted Answer · 2015-01-21 03:31:06Z

0

Your problem was probably due to this:

for($reverse = $pos--; $reverse > $stringEnd; $reverse--){

More precisely this:

$reverse = $pos--;

Even more precisely this:

$pos--;

Causing a recursive loop, causing $string to get larger than the amount of memory.

I would have done something like this, but I'm not sure what you were trying to do. An expample output would have helped.

Code is untested

This if you want to reverse the words.

If you want to reverse every character...<<\br>

Replace

$words = explode(' ',substr($input,$e,$s-$e));

With

$characters = str_split(substr(($input,$e,$s-$e));

Reverse Routine:

$e = 0;
while(true){
  $s = strpos($input, ',', $e);
  if ($s){
    $words = explode(substr($input,$e,$s-$e));
    $words = array_reverse($words); 
    foreach($words as $val){
      $reverseStr .= $val;
    }
  }
  else{
    break;
  }
  $e = $s+1;
}

edited Jan 21, 2015 at 3:31

answered Jan 21, 2015 at 3:16

Misunderstood

5,6791 gold badge20 silver badges25 bronze badges

2 Comments

FubarP Over a year ago

Thanks, I didn't think that the <code> $pos-- would start a memory leak. I was just assuming it would take the value and subtract it by 1. I fixed it, I still got a ways but yeah hopefully I can get there using my code instead of the 5 lines it would of actually taken to do this.

Misunderstood Over a year ago

Typical syntax in a for loop is the first term is a fixed and not dynamic.

Collectives™ on Stack Overflow

php $string memory leak

2 Answers 2

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related