Ordering array from PHP called by AJAX not working

Question

I'm doing this now:

  $.ajax({
        url: 'full_db.php',
        type: 'GET',
        dataType: 'JSON',
        data: {col_name: firstSel},
        success: function(data) {    
         var full_options = [];
          $.each(data, function (i, data) {
         full_options.push(data.age);
        full_options.sort(function(a, b){
        return a.age - b.age;
     });

     $('#second_select').append("<option>" + data.age + "</option>");
  });
}
});

This appends all of the distinct ages to my select (second_select) and if I console log full_options I get this:

["55", "98", "34", "30", "45", "29", "26", "22", "37", "42", "32", "33", "36", "35", "56", "46", "25", "54", "86"]

I'm looking to get this in ascending order (e.g.: 22, 25, 26, 29,...).

What am I doing wrong here that I'm getting an unordered array?

If you are doing a DB call do the sorting in the SELECT statement. ORDER BY column_name DESC — Panama Jack
– Panama Jack, Commented Jan 21, 2015 at 21:08
Out of curiosity, if you are sorting them in PHP, why the extra sort in JS after the AJAX call? — Crackertastic
– Crackertastic, Commented Jan 21, 2015 at 21:11
what am i doing wrong .. your sort function assumes an array of objects with property age but when you push data.age into array you are only pushing in a primitive value not an object — charlietfl
– charlietfl, Commented Jan 21, 2015 at 21:30

Panama Jack · Accepted Answer · 2015-01-22 06:40:47Z

1

I'm providing an answer for the comment I made.

If you are doing a DB call do the sorting in the query

SELECT * from table ORDER BY column_name DESC

answered Jan 22, 2015 at 6:40

Panama Jack

24.6k11 gold badges65 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jonmrich Over a year ago

No idea how I missed this...thanks for the simple solution, which obviously fixes all my sorting problems at once.

Oleg Dubas · Accepted Answer · 2015-01-21 21:34:00Z

You better sort the data in PHP or MySQL before it gets into JavaScript.
But if you wish, you can surely sort arrays in JavaScript.

full_options.sort(); // ascending order [1,2,3]

Or,

full_options.sort();
full_options.reverse(); // descending order [3,2,1]

Here is what you performing:

full_options.sort(function(a, b){
    return a.age - b.age;
});

This is a more complex way to do it, it sorts ascending. But you perform it in wrong place.
You code should be:

 $.ajax({
     url: 'full_db.php',
     type: 'GET',
     dataType: 'JSON',
     data: {col_name: firstSel},
     success: function(data) 
     {    
          var full_options = [];
          $.each(data, function (i, data) 
          {
              full_options.push(data.age); 
              $('#second_select').append("<option>" + data.age + "</option>");
          });
          full_options.sort();
     }
});

Collectives™ on Stack Overflow

Ordering array from PHP called by AJAX not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related