Check substring of a string

Question

I'm trying to check whether or not the second argument in my program is a substring of the first argument. The problem is that it only work if the substring starts with the same letter of the string.

EDIT: It must be done in C, not C++.

int main(int argc, char **argv){

    if (argc != 3) {
        printf ("Usage: check <string one> <string two>\n");
    }

    int result = my_strstr(argv[1], argv[2]);

    if(result == 1){
        printf("%s is a substring of %s\n", argv[2], argv[1]);
    }
    else{
        printf("%s is not a substring of %s\n", argv[2], argv[1]);
    }
    return 0;
}

… specifically, homework which forbids you to use any library functions besides at? — Potatoswatter
– Potatoswatter, Commented May 11, 2010 at 20:48
Please don't edit questions in a way that answers already given are invalidated. — Georg Fritzsche
– Georg Fritzsche, Commented May 11, 2010 at 23:21

Georg Fritzsche · Accepted Answer · 2010-05-11 20:47:27Z

2

I am assuming homework, so: Take a look at what subStart is initialized with.

answered May 11, 2010 at 20:47

Georg Fritzsche

99.4k26 gold badges198 silver badges238 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

R Samuel Klatchko · Accepted Answer · 2010-05-11 21:25:30Z

1

Your analysis of the problem ("it only work if the substring starts with the same letter of the string") is incorrect and so you are looking for the wrong problem. Since this appears to be homework, I'll just hint at the underlying problem.

While it fails with Michigan and igan it will correctly work with Michigan and higan.

Why does it work for higan and not igan? What is the first letter of igan? What is different about that when it comes to Michigan?

edited May 11, 2010 at 21:25

answered May 11, 2010 at 21:09

R Samuel Klatchko

77k17 gold badges139 silver badges189 bronze badges

Comments

Grumdrig · Accepted Answer · 2010-05-11 20:45:13Z

1

Your algorithm isn't correct.

What you want is nested loops. Loop over the length of str, then loop over the length of sub to see if there is a match starting at that position.

answered May 11, 2010 at 20:45

Grumdrig

17.1k15 gold badges62 silver badges70 bronze badges

Collectives™ on Stack Overflow

Check substring of a string

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related