How to join string List Array On C#

Question

I have array of string from the DataTable, so i'm use this code to get list :

ListTid = string.Join(",", DtTable.AsEnumerable().Select(r => r["NameColumn"].ToString()));

then i have result like this :

LIS1, LIST2, LIST3

How if i want result like this

'List1','List2','List3'

So you want 's in addition to ,s between each element? What have you tried? — SLaks
– SLaks, Commented Jan 26, 2015 at 2:59
Please tell me you're not going to use this in an sql query. It smells like an sql injection vulnerability waiting to happen. — Joel Coehoorn
– Joel Coehoorn, Commented Jan 26, 2015 at 3:07
@JoelCoehoorn I'm hopefully optimistic it's for a CSV write function. — Dai
– Dai, Commented Jan 26, 2015 at 3:28
i have list data on array =1,2,3,4 and want send to query parameter, like this exec storedprocedure @parameter='1','2','3','4' — Muhammad Ibnu Saefullah
– Muhammad Ibnu Saefullah, Commented Jan 26, 2015 at 4:28
Yeah, that's probably vulnerable to sql injection. Look into a table-valued parameter. — Joel Coehoorn
– Joel Coehoorn, Commented Jan 26, 2015 at 5:13

Dai · Accepted Answer · 2015-01-26 03:03:20Z

3

You can continue to use String.Join, just add the extra quotes at the end, like so:

ListTid = '\'' + String.Join("', '", DtTable.AsEnumerable().Select( r => r["NameColumn"].ToString() ) ) + '\'';

answered Jan 26, 2015 at 3:03

Dai

157k31 gold badges314 silver badges436 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

shree.pat18 · Accepted Answer · 2015-01-26 03:07:10Z

2

Add the quotes in your select code, like this:

ListTid = string.Join(",", DtTable.AsEnumerable().Select(r => string.Format("'{0}'",Convert.ToString(r["NameColumn"])));

Note that I have changed your code to use Convert.ToString since it can safely handle nulls, whereas ToString will throw an exception.

answered Jan 26, 2015 at 3:00

shree.pat18

21.8k3 gold badges45 silver badges65 bronze badges

Careful, this approach results in extra strong concatenation operations which means extra memory usage.

thist result '''TED00000'''',''''TED00001'''',''''TED00002'''',''''TED00003''''