Adding a variable to a javascript url call

Question

I want to add a web traffic analysis tool to my site.

To call it, I have to place the following in each page I want to track in my site:

<script type="text/javascript" src="http://analysisTool.js?idtag=123456789&orderid=random"></script>

The idtag 123456789 is the tag id assigned to my site

And orderid will be a random number to each page I want to track (it is the way the tool works)

As I don't want to edit the pages if I ever need to change this orderid, I have created myjs.js with:

var uid = Math.floor(Math.random()*(100000000-0))+0;

And then, I am doing:

<script type="text/javascript" src="/_includes/myjs.js"></script>
<script type="text/javascript" src="http://analysisTool.js?idtag=123456789& orderid ="+uid></script>

But this must be a wrong way to do it because in the browser tools, in the net chapter, I cannot see the orderid.

I’ve checked the path to myjs.js is correct.

What am I doing wrong?

Thanks!

Nano · Accepted Answer · 2015-01-26 09:24:47Z

1

You have to add the script-tag completely with javascript. You cant use javascript variables like that in the HTML page.

If you want to add a script-tag dynamicly use this script:

var script = document.createElement('script'); //create new tag
script.src = "http://analysisTool.js?idtag=123456789&orderid=" + uid;//set the url with your id
document.getElementsByTagName('head')[0].appendChild(script);//append the scripttag

answered Jan 26, 2015 at 9:24

Nano

1,3976 gold badges20 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Malcolm · Accepted Answer · 2015-01-26 09:22:24Z

0

Please take a look at jQuery getScript().

I think it could solve your problem:

By default, $.getScript() sets the cache setting to false. This appends a >timestamped query parameter to the request URL to ensure that the browser >downloads the script each time it is requested.

And please note that "document.write" also works in this case.

answered Jan 26, 2015 at 9:22

Malcolm

1261 silver badge4 bronze badges

Comments

codependent · Accepted Answer · 2015-01-26 09:24:00Z

0

You were trying to access uid in a wrong way (in the src attribute). It needs to be in a script context so your only option is to add the script dinamically:

<script type="text/javascript" src="/_includes/myjs.js"></script>
<script type="text/javascript">
    var fileref=document.createElement('script')
    fileref.setAttribute("type","text/javascript")
    fileref.setAttribute("src", "http://analysisTool.js?idtag=123456789& orderid ="+uid);
    document.getElementsByTagName("head")[0].appendChild(fileref)
</script>

answered Jan 26, 2015 at 9:24

codependent

24.7k39 gold badges196 silver badges353 bronze badges

Comments

Troy Young · Accepted Answer · 2015-01-26 09:25:58Z

0

please add this js declaration dynamic in your myjs.js. Means create the script tag through your javascript code.

window.onload = function() {
    var script = document.createElement('script');
    script.type = 'text/javascript';
    var uid = Math.floor(Math.random()*(100000000-0))+0;
    script.src = 'http://analysisTool.js?idtag=123456789&orderid=' + uid;
    document.head.appendChild(script);
}

answered Jan 26, 2015 at 9:25

Troy Young

1912 silver badges13 bronze badges

Collectives™ on Stack Overflow

Adding a variable to a javascript url call

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related