Rounding problems in JavaScript

Question

I've got a problem with rounding in JavaScript. I'm using a function for rounding:

function roundup(rnum, rlength){
    var newnumber = Math.round(rnum * Math.pow(10, rlength)) / Math.pow(10, rlength);
    return newnumber;
}

var amount = roundup(2253.825, 3);

Strange thing is, when I round up the number 2253.825, the result is 2253.82 which has to be 2253.83. When I round up the number 5592.825 the result is 5592.83, which is correct.

Any idea how to fix this?

Related: smbc-comics.com/index.php?db=comics&id=2999#comic :) — meskobalazs
– meskobalazs, Commented Jan 28, 2015 at 12:54
@Grimbode, take a look at my fiddle. I added a value 2020.825 and that is working correctly. jsfiddle.net/poqnnxyo/2 — Leon van der Veen
– Leon van der Veen, Commented Jan 28, 2015 at 12:58
Question: Are you trying to round up, or just round? If you want to round up, then switching to Math.ceil should solve your problem. — JLRishe
– JLRishe, Commented Jan 28, 2015 at 13:06

JLRishe · Accepted Answer · 2018-04-24 17:25:58Z

1

Floating point rounding errors are at fault here. 2620.825 * 100 is 262082.49999999997, so when you round it, the result is 262082.

Here is a more robust approach that corrects for this:

function roundup(rnum, rlength) {
    var shifted = rnum * Math.pow(10, rlength),
        rounded = Math.round(shifted),
        delta = Math.abs(shifted - rounded);

    if (delta > 0.4999999 && delta < 0.5) {
        rounded += (rounded < 0 ? -1 : 1);
    }

    return rounded / Math.pow(10, rlength);
}

console.log("2620.825 :=> " + roundup(2620.825, 2));
console.log("2621.825 :=> " + roundup(2621.825, 2));
console.log("2620.8255 :=> " + roundup(2620.8255, 2));

edited Apr 24, 2018 at 17:25

answered Jan 28, 2015 at 13:05

JLRishe

102k19 gold badges138 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:28:31Z

0

The problem shows up inherently because the way IEEE 754 doubles work. If you really want to always get mathematically correct results, you need to use a custom datatype, for example a BigDecimal implementation like this one.

Please also take a look at this answer, as it may be useful.

edited May 23, 2017 at 12:28

CommunityBot

11 silver badge

answered Jan 28, 2015 at 13:00

meskobalazs

16.1k2 gold badges44 silver badges63 bronze badges

Collectives™ on Stack Overflow

Rounding problems in JavaScript

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related