Passing PHP string to JavaScript Function

Question

I am having a issue while passing php string to JavaScript function. When i pass the numeric value it works fine. But when i pass the string it doesn't work

Here is my JavaScript code:

function updateButton(custID, custEmail)
{
alert (custID);
alert (custEmail);
}

And this is my php code:

echo '<td><input id="btnUpdate" type="submit" name="btnUpdate" value = "Update" onclick="updateButton(' . $row['CustomerID']  . ',' .  $row['custEmail'] . ')" /> </td>';

In the above php code $row['CustomerID'] has the numeric value and $row['custEmail'] has the string value.

You have to be aware of the context your output will be used in. You're dumping text from PHP into a javascript-inside-html context. Your text is NAKED - no quotes around, so it'll be treated by JS as variable names or whatever. — Marc B
– Marc B, Commented Jan 29, 2015 at 22:25

MB34 · Accepted Answer · 2015-01-29 22:22:27Z

3

Try this:

echo '<td><input id="btnUpdate" type="submit" name="btnUpdate" value = "Update" onclick="updateButton("' . $row['CustomerID']  . '","' .  $row['custEmail'] . '")" /> </td>';

answered Jan 29, 2015 at 22:22

MB34

4,47613 gold badges66 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

paperpusher · Accepted Answer · 2015-01-29 22:23:39Z

1

You need quotes around the string

echo '<td><input id="btnUpdate" type="submit" name="btnUpdate" value = "Update" onclick="updateButton(' . $row['CustomerID']  . ',\'' .  $row['custEmail'] . '\')" /> </td>';

answered Jan 29, 2015 at 22:23

paperpusher

1157 bronze badges

1 Comment

MB34 Over a year ago

If so, then accept his answer, that is the spirit of this website.

Collectives™ on Stack Overflow

Passing PHP string to JavaScript Function

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related