While loop not looping - Ruby

Question

When str[0] is "a" and str[4] is "b" I get true. However, when "a" is in another position and is separated by three spaces from "b" I get false.

Any help would be great!

def ABCheck(str)

  str.downcase.split()
  x = 0
  while x < str.length - 4
    return true if ((str[x] == "a") && (str[x + 4] =="b"))
      x += 1
    return false

  end     
end

puts ABCheck("azzzb")
#Currently puts "true"
puts ABCheck("bzzabzcb")
#Currently puts "false" - even though it should print true

Yu Hao · Accepted Answer · 2015-02-01 06:25:18Z

4

That's because return false is called before you expected. It should be put outside the loop:

def ABCheck(str)
  str.downcase.split()
  x = 0
  while x < str.length - 4
    return true if ((str[x] == "a") && (str[x + 4] =="b"))
    x += 1
  end  
  return false   
end

answered Feb 1, 2015 at 6:25

Yu Hao

123k50 gold badges252 silver badges305 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

locoboy · Accepted Answer · 2015-02-01 06:46:00Z

0

You're calling false before your while loops is complete. You need to call it after the while loop.

answered Feb 1, 2015 at 6:46

locoboy

39.1k73 gold badges190 silver badges263 bronze badges

Collectives™ on Stack Overflow

While loop not looping - Ruby

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related