Returning multiple values from a function/method

Question

I have a method in my class that I want to return more than one value:

public function lockFields($lockFieldsDBs, $lockValueConstant) {
    if ($lockFieldsDBs == $lockValueConstant) {
        $lockFieldValue = 'readonly="readonly"';
        $lockImage      = 'image_url_goes_here';
    }
    else {
        $lockFieldValue = null;
        $lockImage = null;
    }

    return $lockField;
    return $lockImage;
}


...........


$lockFieldsDBs = 'OK';
$lockValueConstant = 'OK';

$formHandler->lockFields($lockFieldsDBs, $lockValue);

When trying to print out a value like this: echo $lockImage;, I am getting Undefined variable: lockImage.

Why isn't the value being returned?

point 1: you miss to return anything if condition is true, point 2: you cant return 2 variables if you need both, return an array — donald123
– donald123, Commented Feb 3, 2015 at 14:51

silkfire · Accepted Answer · 2015-02-03 15:22:12Z

4

You can return two or more values from a function with help of the list() language construct:

public function lockFields($lockFieldsDBs, $lockValueConstant) {
    if($lockFieldsDBs == $lockValueConstant){
        $lockFieldValue = 'readonly="readonly"';
        $lockImage = 'image_url_goes_here';
    }
    else {
        $lockFieldValue = null;
        $lockImage = null;
    }

    return [$lockField, $lockImage];
}



list($lockField, $lockImage) = $formHandler->lockFields($lockFieldsDBs, $lockValue);

edited Feb 3, 2015 at 15:22

answered Feb 3, 2015 at 14:57

silkfire

26.3k17 gold badges92 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ZYZ123ABC242526 Over a year ago

Hi, should the list line in the class or the when I call the class. Thank you.

silkfire Over a year ago

@ZYZ123ABC242526 Outside the class, right where you're calling the method.

user4228531 · Accepted Answer · 2015-02-03 14:59:34Z

1

The problem is you are returning more than one variable form you function. You can't. you have to assign an array or a list to do this job, to do this use either of these codes before ending your function:

return ['lockField'=>$lockField, 'lockImage'=>$lockImage];

or

return array($lockField, $lockImage);

answered Feb 3, 2015 at 14:59

user4228531

Comments

Jessica · Accepted Answer · 2015-02-03 14:51:10Z

0

You can only return one variable in a PHP function. If you need to return two, you need to use an array (or an object).

public function lockFields($lockFieldsDBs,$lockValueConstant)
{
    if($lockFieldsDBs == $lockValueConstant){
        $lockFieldValue = 'readonly="readonly"';
        $lockImage = 'image_url_goes_here';
    } else {
        $lockFieldValue = null;
        $lockImage = null;
    }
    return ['lockField'=>$lockField, 'lockImage'=>$lockImage];
}

answered Feb 3, 2015 at 14:51

Jessica

6,99630 silver badges39 bronze badges

1 Comment

Niet the Dark Absol Over a year ago

Or yield but that gets a bit more complicated ;)

Paul Lo · Accepted Answer · 2015-02-03 14:52:16Z

0

You cannot return two variables in a php function:

return $lockField;
return $lockImage;

You can put them in an array:

return array($lockField, $lockImage);

to use it:

$response = $formHandler->lockFields($lockFieldsDB,$lockValue)
echo $response[0]; // this is $lockField in your function 
echo $response[1]; // this is $lockImage in your function

answered Feb 3, 2015 at 14:52

Paul Lo

6,1466 gold badges33 silver badges37 bronze badges

Comments

bln_dev · Accepted Answer · 2015-02-03 14:59:05Z

0

$lockImage is a variable inside of the method. Why do you think it will be available globally? To be clear:

public function lockFields($lockFieldsDBs,$lockValueConstant){
  $lockImage = "some value";
  return $lockImage;
}

$formHandler->lockFields($lockFieldsDB,$lockValue);
echo $lockImage; // variable $lockImage does not exists

won't work. It should be:

public function lockFields($lockFieldsDBs,$lockValueConstant){
  $lockImage = "some value";
  return $lockImage;
}

$lockImage = $formHandler->lockFields($lockFieldsDB,$lockValue);
echo $lockImage; // "some value"

The other answers point out that you need to return the value properly. But I think you also do not fetch the return correctly.

edited Feb 3, 2015 at 14:59

answered Feb 3, 2015 at 14:53

bln_dev

2,4373 gold badges31 silver badges45 bronze badges

Collectives™ on Stack Overflow

Returning multiple values from a function/method

5 Answers 5

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related