jQuery plugin question - populate select options with JSON data

Question

I'm trying to fill selects with json data from a web service. I'm getting error 'Object doesn't support this property or method.' when I do this $(this).html(options.join('')); Any ideas what I'm doing wrong?

;(function($) {

    $.fillSelect = {};

    $.fn.fillSelect = function(url, map) {
        var jsonpUrl = url + "?callback=?";        
        $.getJSON(jsonpUrl, function(d) {
           var options = [];
           var txt = map[0];
           var val = map[1];
           options.push('<option>--Select--</option>');
           $.each(d, function(index, item) {
                options.push('<option value="' + item[val] + '">' + item[txt] + '</option>');
           });
           $(this).html(options.join(''));
           //getting error  Object doesn't support this property or method
        };
    };
})(jQuery);

When you do alert(this); before that line, what do you get? — Nick Craver
– Nick Craver, Commented May 13, 2010 at 23:57

nickf · Accepted Answer · 2010-05-14 02:06:01Z

3

The problem is the variable this. In the context you're using, this is probably referring to the jQuery object itself (that is, not the result set). Try this:

$.fn.fillSelect = function (url, map) {
    var $t = this;     // (this) is the jQuery result set

    $.getJSON( ... blah blah,

        $t.html(options.join(''));
    )
}

answered May 14, 2010 at 2:06

nickf

548k199 gold badges660 silver badges727 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dmuun Over a year ago

Yes you were absolutely right 'this' was referring to the jQuery object itself. Thanks for your help.

nickf Over a year ago

@user331884 - if you find an answer helpful, vote it up and accept it by clicking on the links up to the left

Collectives™ on Stack Overflow

jQuery plugin question - populate select options with JSON data

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related