exception (handling) in c#

Question

  catch (Exception ex)
  {
     _errorCode = ErrorCodes.SqlGeneralError;
     CommonTools.vAddToLog(ex, _errorCode, _userID);
     throw new JOVALException(_errorCode);
 }

I use this peace of code to handle error to an custom exception called (JOVALException) but when an exception is occurred it is open "No source available" page and telled me that is no the stack trace is empty How could I solve this problem ?

Edit

 public JOVALException(ErrorCodes _errCode, String _message = "")
        {
            ErrMessage = _message;
            ErrCode = _errCode;

        }

here is my constructor, How can modify it ?

Sebastian Negraszus · Accepted Answer · 2015-02-04 13:31:54Z

5

Put ex into your JOVALException as an inner exception.

public JOVALException(ErrorCodes _errCode, String _message = "",
  Exception innerException = null) : base(_message, innerException)
{
  ErrMessage = _message;
  ErrCode = _errCode;
}

edited Feb 4, 2015 at 13:31

answered Feb 4, 2015 at 13:08

Sebastian Negraszus

12.3k7 gold badges49 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sebastian Negraszus Over a year ago

@RaedAlsaleh You need to add an appropriate constructor to JOVALException that calls the base constructor passing the inner exception. See link.

Dmitrii Bychenko · Accepted Answer · 2015-02-04 13:26:36Z

0

I'd recommend you to modify JOVALException class, by adding a constructor:

  public class JOVALException: Exception {
    ...
    // Note Exception "innerException" argument
    public JOVALException(ErrorCodes _errCode, Exception innerException, String _message = "")
      : base(_message, inner) {
      ...
    }
  }

Another issue: try avoid code duplication

  ErrMessage = _message;

since ErrMessage is, in fact, a duplication of Message propepery; just call a base class constructor.

then

  catch (Exception ex)
  {
     _errorCode = ErrorCodes.SqlGeneralError;
     CommonTools.vAddToLog(ex, _errorCode, _userID);
     throw new JOVALException(_errorCode, ex);  // <- Note "ex"
  }

answered Feb 4, 2015 at 13:26

Dmitrii Bychenko

188k20 gold badges178 silver badges231 bronze badges

Comments

DGibbs · Accepted Answer · 2015-02-06 13:41:15Z

0

When you call throw new JOVALException(_errorCode); you lose the stack trace of the original error.

Just do:

throw;

If you need to throw a JOVALException you'll need to modify your class slightly:

class JOVALException : Exception
{
    public JOVALException(string errorCode, Exception innerException)
        : base(errorCode, innerException)
    {

    }
}

And an example:

 try
 {
      int i = 0;
      int foo = i / i;
 }
 catch (Exception ex)
 {
     _errorCode = ErrorCodes.SqlGeneralError;
     CommonTools.vAddToLog(ex, _errorCode, _userID);
     throw new JOVALException(_errorCode, ex);
 }

edited Feb 6, 2015 at 13:41

answered Feb 4, 2015 at 13:06

DGibbs

14.7k7 gold badges49 silver badges89 bronze badges

1 Comment

Raed Alsaleh Over a year ago

but I need to tell caller method that is "JOVALException" !

Collectives™ on Stack Overflow

exception (handling) in c#

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related