Setting variable to an instance of an object in php

Question

Okay, I am ripping my hair out here...

I clearly am missing something simple. I am trying to prevent database hits, so I am using a simple function that checks to see if there is an instace of the object already in memory, and if it is, returns the instance, and if not, goes and gets it from the database.

private function RetrieveFromMemory($Id, $Object)
{
    $mymap=$this->ColumnMap;
    $key = $this->Key;
    foreach($this->InMemory as $v) {
        if($v->$key == $Id) {
            /*
            foreach (get_object_vars($v) as $key => $value) {
                $Object->$key = $value;
            }
            */
            $Object = $v;
            trace('Retrieved '.get_class($v).' from memory');
            return true;

        }
    }
    return false;
}

If I uncomment the foreach I can fill the properties fine, but it is a new instance. I want the same instance of the thing, but using $Object = $v; does not set $Object to the same instance as $v... It just leaves the original empty object.

Jim Garrison · Accepted Answer · 2015-02-05 03:41:12Z

2

You are attempting to change the value of the parameter $Object inside the function and expecting that change to be visible after the function completes.

PHP passes arguments by value by default, so you either need to

Change the function to return the value it found, and change how you call it; or
Tell PHP to pass parameters by reference: function RetrieveFromMemory($Id, &$Object)

answered Feb 5, 2015 at 3:41

Jim Garrison

87k20 gold badges162 silver badges196 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

chaosaffe Over a year ago

Figured that out after I asked... For future reference php.net/manual/en/language.oop5.references.php#95522 is a good guide, though it does not show an example using a function sadly

ceejayoz · Accepted Answer · 2015-02-05 03:36:22Z

0

You're returning true, not $v.

answered Feb 5, 2015 at 3:36

ceejayoz

181k42 gold badges311 silver badges382 bronze badges

Collectives™ on Stack Overflow

Setting variable to an instance of an object in php

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related