Update single record in mongodb using express and node.js

Question

I want to update a single record by _id in a collection in mongoDB.

UPDATE: I changed the res to req (thanks!) and implemented the db.ObjectId() around the objectId I am passing in and now I get a 500 internal server error.

    "_id" : ObjectId("54d5296711436278137af74b"),
    "username" : "alex",
    "email" : "alex@gmail",
    "fullname" : "alex man",
    "age" : "15",
    "location" : "minneap",
    "gender" : "mal"

This is my ajax call from the client.

    $.ajax({
                    type: 'PUT',
                    data: updatedUser,
                    url: '/users/updateuser/' + globalUserID,
                    dataType: 'JSON'
                }).done(function(response){

This is the routing code.

/*
* PUT to updateuser
*/
router.put('/updateuser/:id', function(req, res) {
var db = req.db;
var userToUpdate = req.params.id;
db.collection('userlist').update(
{ _id: userToUpdate},
   req.body,
    function(err, result){
    res.send(
        (err === null) ? {msg: ''} : {msg: err}
    );
   });
});

I get a 200 response back but my record is not updated. What is wrong with my syntax?

res.send will always send 200. Because it returns either '' or the error with status code 200 OK. If you have an error you should do res.status(500).send('Something broke!'); — silverfighter
– silverfighter, Commented Feb 6, 2015 at 22:49

Brian Noah · Accepted Answer · 2015-02-06 23:11:06Z

5

You need to make sure you're turning the string _id into an ObjectId.

Also, you were using res.body instead of req.body.

router.put('/updateuser/:id', function(req, res) {
    var db = req.db;
    var userToUpdate = req.params.id;
    db.collection('userlist').update({ _id: ObjectId(userToUpdate)}, req.body, function (err, result) {
        res.send(
            (err === null) ? {msg: ''} : {msg: err}
        );
    });
});

Different drivers use a different method to create an ObjectId:

mongoDB native driver: new ObjectId(idString);
mongoJS: db.ObjectId(idString);
mongoSkin: toObjectID(idString);
mongoose: mongoose.Types.ObjectId(idString);

edited Feb 6, 2015 at 23:11

answered Feb 6, 2015 at 22:47

Brian Noah

2,99220 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

javascript Jenkins Over a year ago

I implemented those changes and now get a 500 error. It has something to do with the db.ObjectId() method but I do not know what it is.

Brian Noah Over a year ago

I'm assuming that db is your mongoDB driver, so it should work. db.ObjectId() might not be a method of created an object id for your database driver. It is for mongojs, but if you are using another mongo driver, db.ObjectId() might not work. Also, what is the error stack received?

Brian Noah Over a year ago

you can try new ObjectID(idString); this is the method the native mongoDB uses. Mongoose you use mongoose.Types.ObjectId(string);

javascript Jenkins Over a year ago

My db is the "mongo.db(url)" database connection. The error stack from the node app doesn't say much. PUT /users/updateuser/54d3ba6cfe49c07c04733fac 500 42.412 ms

javascript Jenkins Over a year ago

I am using mongoskin fyi

|

Yuri Zarubin · Accepted Answer · 2015-02-06 22:43:10Z

1

It should be req.body, not res.body

db.collection('userlist').update(
{ _id: userToUpdate},
   res.body -> should be req.body

answered Feb 6, 2015 at 22:43

Yuri Zarubin

11.7k4 gold badges33 silver badges34 bronze badges

Collectives™ on Stack Overflow

Update single record in mongodb using express and node.js

2 Answers 2

9 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related