Using echo within conditional statement

Question

I'm using a conditional statement to check what language the page is on. It's fine when I just need to output HTML, but the particular line I need to translate already has an echo statement in it and I am unsure how to echo the whole statement.

The line:

<div class="timer-col"> <span id="days"></span> <span class="timer-type"><?php _e('days', 'framework'); ?></span> </div>

My code:

<?php
$mylocale = get_bloginfo('language');
if($mylocale == 'en' || $mylocale == 'en-US') {
    echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type"><?php _e('days ', 'framework'); ?></span> </div>';
} else {
    echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type"><?php _e('dien', 'framework'); ?></span> </div>';
}
?>

You're already in PHP with <?php and ?> remove those from the echos. — Funk Forty Niner
– Funk Forty Niner, Commented Feb 7, 2015 at 4:38
You have php tags in php tags! (Use concatenation: php.net/manual/en/language.operators.string.php) — Rizier123
– Rizier123, Commented Feb 7, 2015 at 4:38
You may want to put each of those echo statements on two separate lines... If this is WordPress' _e(), it works differently than a returned string that can be concatenated. (e.g. by putting the echo '<div ..> part on one line, and putting the _e(...) part on another.) — summea
– summea, Commented Feb 7, 2015 at 4:41

summea · Accepted Answer · 2015-02-07 04:49:33Z

2

If this is WordPress and its _e() function, you may want to break up your echo lines into something like the following example:

<?php
$mylocale = get_bloginfo('language');
if($mylocale == 'en' || $mylocale == 'en-US') {
    echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type">';
    _e('days ', 'framework');
    echo '</span> </div>';
} else {
    echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type">';
    _e('dien', 'framework');
    echo '</span> </div>';
}
?>

This is because _e() does not return a string (that normally could be used with string concatenation). Instead, e() simply prints out translated text (without returning anything).

I've noticed that if I try to use e() inside of a string, I get unexpected placement results of where e() ends up echoing the translated text.

answered Feb 7, 2015 at 4:49

summea

7,6534 gold badges35 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

vytfla Over a year ago

Hmm thanks, that makes sense. For some reason now all the timers are reading as the day timer.

vytfla Over a year ago

It works! Thank you, I forgot to change the span id's to reflect the correct unit.

summea Over a year ago

@vytfla Glad to hear it! :)

Jun Rikson · Accepted Answer · 2015-02-07 04:41:32Z

0

Have you tried this :

<?php
$mylocale = get_bloginfo('language');
if($mylocale == 'en' || $mylocale == 'en-US') {
    echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type">'. _e('days ', 'framework').'</span> </div>';
} else {
    echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type">'. _e('dien', 'framework').'</span> </div>';
}
?>

answered Feb 7, 2015 at 4:41

Jun Rikson

1,9041 gold badge22 silver badges43 bronze badges

1 Comment

vytfla Over a year ago

I did, but it made all the text inline and work funny.

Community · Accepted Answer · 2017-05-23 12:28:31Z

0

You'll want to write your echo statements something like this:

echo '<div class="timer-col"> <span id="days"></span> <span class="timer-type">' . _e("days", "framework") . '</span> </div>';

With single quotes around the HTML echoed parts, double quotes inside the single quotes, and PHP concatenated with '.'

1 Comment

vytfla Over a year ago

This puts the text outside of the span.

Collectives™ on Stack Overflow

Using echo within conditional statement

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related