React component how to simplify this onClick function?

Question

This is not really a React specific question, but I think it helps to know the context. In a component I'm generating some table rows. Each row needs an onClick function that passes an id to the components handleUnlink method.

I got it to work with the code below, but it's making my head spin a bit and I have a feeling that this could be done in a simpeler way. Am I right?

var fn = function(id){
  return function(){
    this.handleUnlink(id);
  }.bind(this);
}.bind(this); 

var linkedListHtml = this.state.linkedList.map( p => {
  return(
    <tr key={p.id}>
    <td>{p.name}</td>
    <td><mui.Icon icon='action-highlight-remove' onClick={fn(p.id)}/></td>
    </tr>);
});

Jonny Buchanan · Accepted Answer · 2015-02-09 10:08:05Z

3

Function.prototype.bind() also does partial application of any additional arguments, so you should be able to do this instead:

onClick={this.handleUnlink.bind(this, p.id)}

Bonus: The this argument to bind() is redundant if you're using React.createClass() to create your component, as it auto-binds methods for you, so I usually end up writing a partial helper:

'use strict';
var slice = Array.prototype.slice
function partial(fn) {
  var partialArgs = slice.call(arguments, 1)
  return function() {
    return fn.apply(this, partialArgs.concat(slice.call(arguments)))
  }
}
module.exports = partial

...

var partial = require('./utils/partial')
// ...
onClick={partial(this.handleUnlink, p.id)}

edited Feb 9, 2015 at 10:08

answered Feb 8, 2015 at 21:41

Jonny Buchanan

62.9k17 gold badges147 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Thijs Koerselman Over a year ago

Perfect, that's even better then I hoped for. \o/

Collectives™ on Stack Overflow

React component how to simplify this onClick function?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related