Class PHP methods get and set

Question

I have this class:

<?php
    class Test {

        private $_ID;
        private $_NAME;
        private $_AGE;

        public function setID() { $this->_ID++; }
        public function getID() { return $this->_ID; }

        public function setNAME($element) { $this->_NAME = $element; }
        public function getNAME() { return $this->_NAME; }

        public function setAGE($element) { $this->_AGE = $element; }
        public function getAGE() { return $this->_AGE; }

        public function addUser($name, $age) {
            Test::setID();
            Test::setNAME($name);
            Test::setAGE($age);

            echo "OK";
        }
    }
?>

I want to create objects of this class, and assign the data with the function addUser like this:

$test = new Test();
$test:: addUser("Peter", "12"); but I have errors.

I have this errors:

Strict Standards: Non-static method Test::addUser() should not be called statically in /var/www/public/testManu.php on line 13

Strict Standards: Non-static method Test::setID() should not be called statically in /var/www/public/class/Test.php on line 18

Fatal error: Using $this when not in object context in /var/www/public/class/Test.php on line 8

I have problems with variable scope. Could somebody tell me what it is my problem????

"I have problems with variable scope" is too vague - what symptoms do you see? Errors? Unexpected behaviour? Any error messages? — J Richard Snape
– J Richard Snape, Commented Feb 9, 2015 at 11:10

Axel Amthor · Accepted Answer · 2015-02-09 11:10:50Z

2

change this:

 ...
 public function addUser($name, $age) {
        $this->setID();
        $this->setNAME($name);
        $this->setAGE($age);

        echo "OK";
    }
 ...

Calling like Classname::function() is only valid for static methods. You have a dedicated instance which need to be addressed with the construct $this->function().

And thus:

   ...
  $test->addUser("Peter", "12"); but I have errors.

answered Feb 9, 2015 at 11:10

Axel Amthor

11.1k1 gold badge28 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Seti Over a year ago

His class is called Test the other one he used is Teprohelper. So the usage is probable (you dont know what Teprohelper is, but with names its not the Test class therefore cannot be changed into $this;

Despotars Over a year ago

I have corrected the description of my mistake, now is correct

Axel Amthor Over a year ago

@Seti Just an assumption that Teprohelper is miss typed and it should be the same class/object as you may see by the methods which are called - defined in class Test

Axel Amthor Over a year ago

@Seti yepp. He's messed up with object references

Seti Over a year ago

Yep, he fixed that, but still. What is usage of class that can store only one user at its best?

Seti · Accepted Answer · 2015-02-09 11:13:28Z

2

$test = new Test();
$test -> addUser("Peter", "12"); #now no errors

answered Feb 9, 2015 at 11:13

Seti

2,31618 silver badges27 bronze badges

2 Comments

Seti Over a year ago

But still. Can you tell us what you want to achieve exactly? You are using two classes here. One Test and one Teprohelper...

Axel Amthor Over a year ago

IGNORE TEPSOHELPER IT'S A TYPO!

Daan · Accepted Answer · 2015-02-09 11:32:19Z

1

This should work for you:

<?php
    class Test {

        private static $_ID = 1;
        private static $_NAME;
        private static $_AGE;

        public static function setID() { self::$_ID++; }
        public static function getID() { return self::$_ID; }

        public static function setNAME($element) { self::$_NAME = $element; }
        public static function getNAME() { return self::$_NAME; }

        public static function setAGE($element) { self::$_AGE = $element; }
        public static function getAGE() { return self::$_AGE; }

        public static function addUser($name, $age) {
            self::setID();
            self::setNAME($name);
            self::setAGE($age);

            echo "OK";
        }
    }

$test = new Test(); /*You don't need to instantiate the class 
                      because you're calling a static function*/
$test:: addUser("Peter", "12"); but I have errors.
?>

edited Feb 9, 2015 at 11:32

answered Feb 9, 2015 at 11:16

Daan

12.3k6 gold badges36 silver badges51 bronze badges

4 Comments

Seti Over a year ago

I think its not what he wanted to achieve... Now he have one class that can store one user.... And thats all...

Axel Amthor Over a year ago

Should work, but the question is whether he actually wants static methods on a non-instance or an instance. As he's instantiating the object, I assume that it shouldn't be static.

Despotars Over a year ago

I have this error: Parse error: syntax error, unexpected '++' (T_INC) in /var/www/public/class/Test.php on line 8

Daan Over a year ago

You need to assign a number to private static $_ID I thought you already had set it, I've updated my answer

Collectives™ on Stack Overflow

Class PHP methods get and set

3 Answers 3

5 Comments

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related